From: David Miller <davem@davemloft.net>
To: tlfalcon@linux.vnet.ibm.com
Cc: netdev@vger.kernel.org, nfont@linux.vnet.ibm.com,
jallen@linux.vnet.ibm.com
Subject: Re: [PATCH net-next] ibmvnic: Enable TSO support
Date: Thu, 25 May 2017 14:49:35 -0400 (EDT) [thread overview]
Message-ID: <20170525.144935.732861960034229990.davem@davemloft.net> (raw)
In-Reply-To: <20170525.144626.1787511445330790842.davem@davemloft.net>
From: David Miller <davem@davemloft.net>
Date: Thu, 25 May 2017 14:46:26 -0400 (EDT)
> From: Thomas Falcon <tlfalcon@linux.vnet.ibm.com>
> Date: Wed, 24 May 2017 21:29:26 -0500
>
>> The feature is also enabled by a module parameter.
>> This parameter is necessary because TSO can not easily be
>> enabled or disabled in firmware without reinitializing the driver.
>
> Sorry, this is unacceptable. When I say no module parameters,
> I really really mean it.
>
> Users should not be burdoned with having to know a special knob for
> every driver in order to adjust what is a generic feature.
>
> You'll have to find another way to accomodate this.
Also, TSO helps without SG only because you haven't implemented
support for xmit_more in this driver to decrease the number of
doorball updates and VM enters.
I bet if you added xmit_more support, TSO wouldn't give you much
if any performance boost if you have to linearize.
next prev parent reply other threads:[~2017-05-25 18:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-25 2:29 [PATCH net-next] ibmvnic: Enable TSO support Thomas Falcon
2017-05-25 3:57 ` kbuild test robot
2017-05-25 18:46 ` David Miller
2017-05-25 18:49 ` David Miller [this message]
2017-05-26 16:11 ` Thomas Falcon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170525.144935.732861960034229990.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jallen@linux.vnet.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=nfont@linux.vnet.ibm.com \
--cc=tlfalcon@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).