From: David Miller <davem@davemloft.net>
To: jiri@resnulli.us
Cc: netdev@vger.kernel.org, idosch@mellanox.com, mlxsw@mellanox.com,
stephen@networkplumber.org, nikolay@cumulusnetworks.com
Subject: Re: [patch net-next 00/18] mlxsw: Improve extensibility
Date: Fri, 26 May 2017 15:21:39 -0400 (EDT) [thread overview]
Message-ID: <20170526.152139.1067635701572902907.davem@davemloft.net> (raw)
In-Reply-To: <20170526.152035.708896761272676930.davem@davemloft.net>
From: David Miller <davem@davemloft.net>
Date: Fri, 26 May 2017 15:20:35 -0400 (EDT)
> Nice cleanups and consolidation, but like Nikolay I'm not so sure
> about all the exports.
>
> It might even be cleaner (believe it or not) to have the bridge
> structure (or at least a subset of it) be something public that
> drivers can query using inline helpers.
Just to be clear I did apply this series, and the above is about
future considerations.
Thanks.
prev parent reply other threads:[~2017-05-26 19:21 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-26 6:37 [patch net-next 00/18] mlxsw: Improve extensibility Jiri Pirko
2017-05-26 6:37 ` [patch net-next 01/18] bridge: Export VLAN filtering state Jiri Pirko
2017-05-26 8:55 ` Nikolay Aleksandrov
2017-05-26 14:02 ` Ido Schimmel
2017-05-26 6:37 ` [patch net-next 02/18] bridge: Export multicast enabled state Jiri Pirko
2017-05-26 8:56 ` Nikolay Aleksandrov
2017-05-26 6:37 ` [patch net-next 03/18] mlxsw: spectrum: Set port's mode according to FID mappings Jiri Pirko
2017-05-26 6:37 ` [patch net-next 04/18] mlxsw: spectrum: Introduce Port-VLAN structure Jiri Pirko
2017-05-26 6:37 ` [patch net-next 05/18] mlxsw: spectrum: Change signature of FID leave function Jiri Pirko
2017-05-26 6:37 ` [patch net-next 06/18] mlxsw: spectrum_router: Replace vPorts with Port-VLAN Jiri Pirko
2017-05-26 6:37 ` [patch net-next 07/18] mlxsw: spectrum: Don't lose bridge port device during enslavement Jiri Pirko
2017-05-26 6:37 ` [patch net-next 08/18] mlxsw: spectrum: Don't create FIDs upon creation of VLAN uppers Jiri Pirko
2017-05-26 6:37 ` [patch net-next 09/18] mlxsw: spectrum: Replace vPorts with Port-VLAN Jiri Pirko
2017-05-26 6:37 ` [patch net-next 10/18] mlxsw: spectrum_router: Allocate FID prior to RIF configuration Jiri Pirko
2017-05-26 6:37 ` [patch net-next 11/18] mlxsw: spectrum_router: Allocate RIF prior to its configuration Jiri Pirko
2017-05-26 6:37 ` [patch net-next 12/18] mlxsw: spectrum_router: Extend the RIF struct Jiri Pirko
2017-05-26 6:37 ` [patch net-next 13/18] mlxsw: spectrum_router: Configure RIFs based on " Jiri Pirko
2017-05-26 6:37 ` [patch net-next 14/18] mlxsw: spectrum_router: Destroy RIF only based on its struct Jiri Pirko
2017-05-26 6:37 ` [patch net-next 15/18] mlxsw: spectrum_router: Flood packets to router after RIF creation Jiri Pirko
2017-05-26 6:37 ` [patch net-next 16/18] mlxsw: spectrum_router: Determine VR first when creating RIF Jiri Pirko
2017-05-26 6:37 ` [patch net-next 17/18] mlxsw: spectrum: Implement common FID core Jiri Pirko
2017-05-26 6:37 ` [patch net-next 18/18] mlxsw: spectrum_router: Implement common RIF core Jiri Pirko
2017-05-26 19:20 ` [patch net-next 00/18] mlxsw: Improve extensibility David Miller
2017-05-26 19:21 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170526.152139.1067635701572902907.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=idosch@mellanox.com \
--cc=jiri@resnulli.us \
--cc=mlxsw@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).