From: Peter Dawson <petedaws@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: kuznet@ms2.inr.ac.ru, jmorris@namei.org, yoshfuji@linux-ipv6.org,
kaber@trash.net, stephen@networkplumber.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] ip6_tunnel, ip6_gre: fix setting of DSCP on encapsulated packets
Date: Fri, 26 May 2017 05:46:27 +1000 [thread overview]
Message-ID: <20170526054627.00dcdeeb@udesktop> (raw)
In-Reply-To: <20170525.121117.810915705354733044.davem@davemloft.net>
On Thu, 25 May 2017 12:11:17 -0400 (EDT)
David Miller <davem@davemloft.net> wrote:
> > Fixes: https://bugzilla.kernel.org/show_bug.cgi?id=195661
>
> This is not the correct way to use the Fixes: tag.
>
> You should specify the commit that introduced the regression
> between 4.9.x and 4.10.x, and that you are fixing here.
Thanks for your review Dave. I'll resubmit the patch with the following detail and just reference the bugzilla in the main body of the commit comment.
Commit 90427ef5d2a4 ("ipv6: fix flow labels when the traffic class is non-0") caused the regression by masking out the flowlabel which exposed the incorrect the handling of the DSCP portion of the flowlabel in ip6_tunnel and ip6_gre.
next prev parent reply other threads:[~2017-05-25 19:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-23 4:36 [PATCH net] ip6_tunnel, ip6_gre: fix setting of DSCP on encapsulated packets Peter Dawson
2017-05-25 16:11 ` David Miller
2017-05-25 19:46 ` Peter Dawson [this message]
2017-05-25 19:49 ` David Miller
2017-05-25 20:08 ` Peter Dawson
2017-05-25 20:33 ` David Miller
2017-05-25 20:35 ` [PATCH net,v2] " Peter Dawson
2017-05-26 18:55 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170526054627.00dcdeeb@udesktop \
--to=petedaws@gmail.com \
--cc=davem@davemloft.net \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).