From: Stephen Hemminger <stephen@networkplumber.org>
To: David Miller <davem@davemloft.net>
Cc: jemele@gmail.com, jemele@acm.org, netdev@vger.kernel.org,
jemele@google.com, mlindner@marvell.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] sky2: Do not deadlock on sky2_hw_down
Date: Fri, 26 May 2017 08:43:08 -0700 [thread overview]
Message-ID: <20170526084308.091a41cb@xeon-e3> (raw)
In-Reply-To: <20170525.235830.986562840550889246.davem@davemloft.net>
On Thu, 25 May 2017 23:58:30 -0400 (EDT)
David Miller <davem@davemloft.net> wrote:
> From: Stephen Hemminger <stephen@networkplumber.org>
> Date: Thu, 25 May 2017 15:05:02 -0700
>
> > Ok, the issue is that lockdep is being stupid and thinking that
> > seqcount's behave like locks.
>
> Well.. they do. That's why they have that annotation.
Your right, but it has some lock like properties because
the seqcount's assumption about odd and even values.
Lockdep is reporting that accessing a sequence count with softirq disabled
and in another case with softirq enabled is a problem.
Potential race theoretical race:
seqcount_begin() ++count
...
---> IRQ
---> Soft IRQ
seqcount_begin() ++count
update stats
seqcount_end() ++count
Anything doing seqcount read during this softirq
will spin thinking still in critical section
But for this case of statistics, there is nothing reading statistics in softirq
context so it can't happen. Lockdep needs to be smarter to know that.
Simplest way to shut this up is to just disable softirq during the cleanup.
prev parent reply other threads:[~2017-05-26 15:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-24 22:43 [PATCH net] sky2: Do not deadlock on sky2_hw_down Joshua Emele
2017-05-25 17:42 ` David Miller
2017-05-25 22:05 ` Francois Romieu
2017-05-25 17:54 ` Stephen Hemminger
2017-05-25 20:21 ` Joshua Emele
2017-05-25 22:05 ` Stephen Hemminger
2017-05-26 3:58 ` David Miller
2017-05-26 15:43 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170526084308.091a41cb@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=davem@davemloft.net \
--cc=jemele@acm.org \
--cc=jemele@gmail.com \
--cc=jemele@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mlindner@marvell.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).