Netdev List
 help / color / mirror / Atom feed
From: Nathan Fontenot <nfont@linux.vnet.ibm.com>
To: netdev@vger.kernel.org, tlfalcon@linux.vnet.ibm.com,
	jallen@linux.vnet.ibm.com
Subject: [PATCH net-next 02/11] ibmvnic: Handle failover after failed init crq
Date: Fri, 26 May 2017 10:30:19 -0400	[thread overview]
Message-ID: <20170526143019.63648.61597.stgit@ltcalpine2-lp14.aus.stglabs.ibm.com> (raw)
In-Reply-To: <20170526142523.63648.62938.stgit@ltcalpine2-lp14.aus.stglabs.ibm.com>

From: John Allen <jallen@linux.vnet.ibm.com>

Handle case where phyp sends a failover after failing to send the
init crq.

Signed-off-by: John Allen <jallen@linux.vnet.ibm.com>
---
 drivers/net/ethernet/ibm/ibmvnic.c |   11 ++++++++++-
 drivers/net/ethernet/ibm/ibmvnic.h |    2 +-
 2 files changed, 11 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c
index 4997de4..1f7cf6f 100644
--- a/drivers/net/ethernet/ibm/ibmvnic.c
+++ b/drivers/net/ethernet/ibm/ibmvnic.c
@@ -3167,6 +3167,8 @@ static void ibmvnic_handle_crq(union ibmvnic_crq *crq,
 		switch (gen_crq->cmd) {
 		case IBMVNIC_CRQ_INIT:
 			dev_info(dev, "Partner initialized\n");
+			adapter->from_passive_init = true;
+			complete(&adapter->init_done);
 			break;
 		case IBMVNIC_CRQ_INIT_COMPLETE:
 			dev_info(dev, "Partner initialization complete\n");
@@ -3481,11 +3483,18 @@ static int ibmvnic_init(struct ibmvnic_adapter *adapter)
 		return rc;
 	}
 
+	adapter->from_passive_init = false;
+
 	init_completion(&adapter->init_done);
 	ibmvnic_send_crq_init(adapter);
 	if (!wait_for_completion_timeout(&adapter->init_done, timeout)) {
 		dev_err(dev, "Initialization sequence timed out\n");
-		release_crq_queue(adapter);
+		return -1;
+	}
+
+	if (adapter->from_passive_init) {
+		adapter->state = VNIC_OPEN;
+		adapter->from_passive_init = false;
 		return -1;
 	}
 
diff --git a/drivers/net/ethernet/ibm/ibmvnic.h b/drivers/net/ethernet/ibm/ibmvnic.h
index 4816e04..fa6ac4e 100644
--- a/drivers/net/ethernet/ibm/ibmvnic.h
+++ b/drivers/net/ethernet/ibm/ibmvnic.h
@@ -1031,5 +1031,5 @@ struct ibmvnic_adapter {
 	struct list_head rwi_list;
 	struct work_struct ibmvnic_reset;
 	bool resetting;
-	bool napi_enabled;
+	bool napi_enabled, from_passive_init;
 };

  parent reply	other threads:[~2017-05-26 14:42 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-26 14:30 [PATCH net-next 00/11] ibmvnic: Driver updates Nathan Fontenot
2017-05-26 14:30 ` [PATCH net-next 01/11] ibmvnic: Track state of adapter napis Nathan Fontenot
2017-05-26 14:30 ` Nathan Fontenot [this message]
2017-05-26 14:30 ` [PATCH net-next 03/11] ibmvnic: Send gratuitous arp on reset Nathan Fontenot
2017-05-26 14:30 ` [PATCH net-next 04/11] ibmvnic: Fix cleanup of SKB's on driver close Nathan Fontenot
2017-05-26 14:30 ` [PATCH net-next 05/11] ibmvnic: Non-fatal error handling Nathan Fontenot
2017-05-26 14:30 ` [PATCH net-next 06/11] ibmvnic: Halt TX and report carrier off on H_CLOSED return code Nathan Fontenot
2017-05-26 14:30 ` [PATCH net-next 07/11] ibmvnic: Deactivate RX pool buffer replenishment on H_CLOSED Nathan Fontenot
2017-05-26 14:30 ` [PATCH net-next 08/11] ibmvnic: Check adapter state during ibmvnic_poll Nathan Fontenot
2017-05-26 14:31 ` [PATCH net-next 09/11] ibmvnic: Reset the CRQ queue during driver reset Nathan Fontenot
2017-05-26 14:31 ` [PATCH net-next 10/11] ibmvnic: Reset tx/rx pools on " Nathan Fontenot
2017-05-26 14:31 ` [PATCH net-next 11/11] ibmvnic: Reset sub-crqs during " Nathan Fontenot
2017-05-26 19:33 ` [PATCH net-next 00/11] ibmvnic: Driver updates David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170526143019.63648.61597.stgit@ltcalpine2-lp14.aus.stglabs.ibm.com \
    --to=nfont@linux.vnet.ibm.com \
    --cc=jallen@linux.vnet.ibm.com \
    --cc=netdev@vger.kernel.org \
    --cc=tlfalcon@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox