From: Alexey Dobriyan <adobriyan@gmail.com>
To: Linyu.Yuan@alcatel-sbell.com.cn
Cc: netdev@vger.kernel.org, davem@davemloft.net
Subject: Re: [PATCH net-next] net: ndisc.c: reduce size of __ndisc_fill_addr_option()
Date: Sat, 27 May 2017 18:15:14 +0300 [thread overview]
Message-ID: <20170527151514.GA3347@avx2> (raw)
> --- a/net/ipv6/ndisc.c
> +++ b/net/ipv6/ndisc.c
> @@ -148,17 +148,18 @@ void __ndisc_fill_addr_option(struct sk_buff *skb, int type, void *data,
> space -= data_len;
> - if (space > 0)
> - memset(opt, 0, space);
> +
> + memset(opt, 0, space);
This can't be right.
And what size are you reducing?
next reply other threads:[~2017-05-27 15:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-27 15:15 Alexey Dobriyan [this message]
2017-05-30 3:31 ` [PATCH net-next] net: ndisc.c: reduce size of __ndisc_fill_addr_option() David Miller
2017-05-30 4:24 ` Joe Perches
-- strict thread matches above, loose matches on Subject: below --
2017-05-26 22:00 yuan linyu
2017-05-30 3:30 ` David Miller
2017-05-30 3:41 ` Joe Perches
2017-05-30 3:42 ` David Ahern
2017-05-31 0:07 ` YUAN Linyu
2017-05-31 0:29 ` YUAN Linyu
2017-05-31 0:39 ` David Ahern
2017-05-31 1:00 ` YUAN Linyu
2017-05-31 0:06 ` YUAN Linyu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170527151514.GA3347@avx2 \
--to=adobriyan@gmail.com \
--cc=Linyu.Yuan@alcatel-sbell.com.cn \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).