netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Mark Bloch <markb@mellanox.com>
Cc: Roopa Prabhu <roopa@cumulusnetworks.com>,
	"davem@davemloft.net" <davem@davemloft.net>,
	Jiri Benc <jbenc@redhat.com>, pravin shelar <pshelar@ovn.org>,
	Alexander Duyck <aduyck@mirantis.com>,
	Nicolas Dichtel <nicolas.dichtel@6wind.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	Balki Raman <ramanb@cumulusnetworks.com>
Subject: Re: vxlan: use after free error
Date: Mon, 29 May 2017 08:32:47 -0700	[thread overview]
Message-ID: <20170529083247.12b1cb60@xeon-e3> (raw)
In-Reply-To: <b04f5f7e-dca1-b219-eb52-03f58fd3823e@mellanox.com>

On Mon, 29 May 2017 09:28:52 +0300
Mark Bloch <markb@mellanox.com> wrote:

> In my patch I've added the code inside vxlan_sock_release()
> after we do:
>         rcu_assign_pointer(vxlan->vn6_sock, NULL);
>         rcu_assign_pointer(vxlan->vn4_sock, NULL);

Use RCU_INIT_POINTER when assigning NULL. A barrier is not necessary.

  reply	other threads:[~2017-05-29 15:32 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-28 10:49 vxlan: use after free error Mark Bloch
2017-05-29  2:50 ` Roopa Prabhu
2017-05-29  6:28   ` Mark Bloch
2017-05-29 15:32     ` Stephen Hemminger [this message]
2017-05-29 18:37     ` Roopa Prabhu
2017-05-30 11:47       ` Jiri Benc
2017-05-30 11:54         ` Jiri Benc
2017-05-30 11:53       ` Jiri Benc

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170529083247.12b1cb60@xeon-e3 \
    --to=stephen@networkplumber.org \
    --cc=aduyck@mirantis.com \
    --cc=davem@davemloft.net \
    --cc=jbenc@redhat.com \
    --cc=markb@mellanox.com \
    --cc=netdev@vger.kernel.org \
    --cc=nicolas.dichtel@6wind.com \
    --cc=pshelar@ovn.org \
    --cc=ramanb@cumulusnetworks.com \
    --cc=roopa@cumulusnetworks.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).