From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [for-next 4/6] net/mlx5: FPGA, Add basic support for Innova Date: Mon, 29 May 2017 10:02:52 -0600 Message-ID: <20170529160252.GA27550@obsidianresearch.com> References: <20170523114404.20387-5-saeedm@mellanox.com> <20170524165059.42lmrwzzcxvi2sf7@ast-mbp> <20170526030701.du4345mbprhcwjyi@ast-mbp> <20170526175624.5xxflpf24je5673h@ast-mbp> <20170526181517.GA3860@obsidianresearch.com> <20170529153131.GB7924@obsidianresearch.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Alexei Starovoitov , Saeed Mahameed , "David S. Miller" , Doug Ledford , "netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "jsorensen-b10kYP2dOMg@public.gmane.org" , Andy Shevchenko , "linux-fpga-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Alan Tull , "yi1.li-VuQAYsv1563Yd54FQh9/CA@public.gmane.org" , Boris Pismenny To: Ilan Tayari Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: netdev.vger.kernel.org On Mon, May 29, 2017 at 03:58:33PM +0000, Ilan Tayari wrote: > > From: Jason Gunthorpe [mailto:jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org] > > Subject: Re: [for-next 4/6] net/mlx5: FPGA, Add basic support for Innova > > > > On Sun, May 28, 2017 at 07:22:27AM +0000, Ilan Tayari wrote: > > > > > This is neither PCI-bar mapped, nor mailbox command. > > > The FPGA is indeed a bump-on-the-wire. > > > (It has I2C to the CX4 chip, but that is for debug purposes, and too > > slow > > > to perform real programming) > > > > Wait.. So if it truely has nothing to do with the existing mellanox > > driver, then nothing more than the fpga loader should be in the mlx5 > > directory? > > True, except in specific cases when the FPGA may mangle the packets in > a way that the netdevice configures, and the driver needs to adapt the > data path. > Such is the case of IPSec and TLS offloads. > Those are tied to the mlx5 Ethernet driver (isolated with a kconfig). But there is nothing stopping this sort of FPGA mangling logic being downstream of any NIC, Mellanox is just the first to do this. I think you'd be better to add something to the net stack to model this post-nic mangling hardware, than trying to hide it in a driver. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html