From: David Miller <davem@davemloft.net>
To: gpiccoli@linux.vnet.ibm.com
Cc: netdev@vger.kernel.org, muvic@linux.vnet.ibm.com,
porcusbr@gmail.com, ganeshgr@chelsio.com, hariprasad@chelsio.com
Subject: Re: [PATCH net] cxgb4: avoid crash on PCI error recovery path
Date: Tue, 30 May 2017 12:16:30 -0400 (EDT) [thread overview]
Message-ID: <20170530.121630.85776802788069421.davem@davemloft.net> (raw)
In-Reply-To: <20170529020701.27765-1-gpiccoli@linux.vnet.ibm.com>
From: "Guilherme G. Piccoli" <gpiccoli@linux.vnet.ibm.com>
Date: Sun, 28 May 2017 23:07:01 -0300
> During PCI error recovery process, specifically on eeh_err_detected()
> we might have a NULL netdev struct, hence a direct dereference will
> lead to a kernel oops. This was observed with latest upstream kernel
> (v4.12-rc2) on Chelsio adapter T422-CR in PowerPC machines.
>
> This patch checks for NULL pointer and avoids the crash, both in
> eeh_err_detected() and eeh_resume(). Also, we avoid to trigger
> a fatal error or to try disabling interrupts on FW during PCI
> error recovery, because: (a) driver might not be able to accurately
> access PCI regions in this case, and (b) trigger a fatal error
> _during_ the recovery steps is a mistake that could prevent the
> recovery path to complete successfully.
>
> Reported-by: Harsha Thyagaraja <hathyaga@in.ibm.com>
> Signed-off-by: Guilherme G. Piccoli <gpiccoli@linux.vnet.ibm.com>
Applied, thanks.
prev parent reply other threads:[~2017-05-30 16:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-29 2:07 [PATCH net] cxgb4: avoid crash on PCI error recovery path Guilherme G. Piccoli
2017-05-30 16:16 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170530.121630.85776802788069421.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ganeshgr@chelsio.com \
--cc=gpiccoli@linux.vnet.ibm.com \
--cc=hariprasad@chelsio.com \
--cc=muvic@linux.vnet.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=porcusbr@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).