* [PATCH] net: dsa: mv88e6xxx: Add missing static to stub functions
@ 2017-05-29 12:56 Arnd Bergmann
2017-05-29 15:01 ` Vivien Didelot
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Arnd Bergmann @ 2017-05-29 12:56 UTC (permalink / raw)
To: Andrew Lunn, Vivien Didelot, Florian Fainelli
Cc: Arnd Bergmann, David S. Miller, netdev, linux-kernel
'static' was not enough, the helpers must be 'static inline'
net/dsa/mv88e6xxx/global2.h:123:12: error: 'mv88e6xxx_g2_misc_4_bit_port' defined but not used [-Werror=unused-function]
net/dsa/mv88e6xxx/global2.h:117:12: error: 'mv88e6xxx_g2_pvt_write' defined but not used [-Werror=unused-function]
Fixes: c21fbe29f858 ("net: dsa: mv88e6xxx: Add missing static to stub functions")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/net/dsa/mv88e6xxx/global2.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/dsa/mv88e6xxx/global2.h b/drivers/net/dsa/mv88e6xxx/global2.h
index d8d3c5abb2a1..14c0be98e0a4 100644
--- a/drivers/net/dsa/mv88e6xxx/global2.h
+++ b/drivers/net/dsa/mv88e6xxx/global2.h
@@ -114,13 +114,13 @@ static inline int mv88e6xxx_g2_set_eeprom16(struct mv88e6xxx_chip *chip,
return -EOPNOTSUPP;
}
-static int mv88e6xxx_g2_pvt_write(struct mv88e6xxx_chip *chip, int src_dev,
- int src_port, u16 data)
+static inline int mv88e6xxx_g2_pvt_write(struct mv88e6xxx_chip *chip,
+ int src_dev, int src_port, u16 data)
{
return -EOPNOTSUPP;
}
-static int mv88e6xxx_g2_misc_4_bit_port(struct mv88e6xxx_chip *chip)
+static inline int mv88e6xxx_g2_misc_4_bit_port(struct mv88e6xxx_chip *chip)
{
return -EOPNOTSUPP;
}
--
2.9.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] net: dsa: mv88e6xxx: Add missing static to stub functions
2017-05-29 12:56 [PATCH] net: dsa: mv88e6xxx: Add missing static to stub functions Arnd Bergmann
@ 2017-05-29 15:01 ` Vivien Didelot
2017-05-29 15:30 ` Andrew Lunn
2017-05-30 18:08 ` David Miller
2 siblings, 0 replies; 6+ messages in thread
From: Vivien Didelot @ 2017-05-29 15:01 UTC (permalink / raw)
To: Arnd Bergmann, Andrew Lunn, Florian Fainelli
Cc: Arnd Bergmann, David S. Miller, netdev, linux-kernel
Hi Arnd,
Arnd Bergmann <arnd@arndb.de> writes:
> 'static' was not enough, the helpers must be 'static inline'
>
> net/dsa/mv88e6xxx/global2.h:123:12: error: 'mv88e6xxx_g2_misc_4_bit_port' defined but not used [-Werror=unused-function]
> net/dsa/mv88e6xxx/global2.h:117:12: error: 'mv88e6xxx_g2_pvt_write' defined but not used [-Werror=unused-function]
>
> Fixes: c21fbe29f858 ("net: dsa: mv88e6xxx: Add missing static to stub functions")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Thanks,
Vivien
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] net: dsa: mv88e6xxx: Add missing static to stub functions
2017-05-29 12:56 [PATCH] net: dsa: mv88e6xxx: Add missing static to stub functions Arnd Bergmann
2017-05-29 15:01 ` Vivien Didelot
@ 2017-05-29 15:30 ` Andrew Lunn
2017-05-29 21:06 ` Arnd Bergmann
2017-05-30 18:08 ` David Miller
2 siblings, 1 reply; 6+ messages in thread
From: Andrew Lunn @ 2017-05-29 15:30 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Vivien Didelot, Florian Fainelli, David S. Miller, netdev,
linux-kernel
On Mon, May 29, 2017 at 02:56:01PM +0200, Arnd Bergmann wrote:
> 'static' was not enough, the helpers must be 'static inline'
>
> net/dsa/mv88e6xxx/global2.h:123:12: error: 'mv88e6xxx_g2_misc_4_bit_port' defined but not used [-Werror=unused-function]
> net/dsa/mv88e6xxx/global2.h:117:12: error: 'mv88e6xxx_g2_pvt_write' defined but not used [-Werror=unused-function]
>
> Fixes: c21fbe29f858 ("net: dsa: mv88e6xxx: Add missing static to stub functions")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Hi Arnd
Dave merged my fix yesterday.
Andrew
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] net: dsa: mv88e6xxx: Add missing static to stub functions
2017-05-29 15:30 ` Andrew Lunn
@ 2017-05-29 21:06 ` Arnd Bergmann
2017-05-30 16:50 ` Andrew Lunn
0 siblings, 1 reply; 6+ messages in thread
From: Arnd Bergmann @ 2017-05-29 21:06 UTC (permalink / raw)
To: Andrew Lunn
Cc: Vivien Didelot, Florian Fainelli, David S. Miller, Networking,
Linux Kernel Mailing List
On Mon, May 29, 2017 at 5:30 PM, Andrew Lunn <andrew@lunn.ch> wrote:
> On Mon, May 29, 2017 at 02:56:01PM +0200, Arnd Bergmann wrote:
>> 'static' was not enough, the helpers must be 'static inline'
>>
>> net/dsa/mv88e6xxx/global2.h:123:12: error: 'mv88e6xxx_g2_misc_4_bit_port' defined but not used [-Werror=unused-function]
>> net/dsa/mv88e6xxx/global2.h:117:12: error: 'mv88e6xxx_g2_pvt_write' defined but not used [-Werror=unused-function]
>>
>> Fixes: c21fbe29f858 ("net: dsa: mv88e6xxx: Add missing static to stub functions")
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> Hi Arnd
>
> Dave merged my fix yesterday.
Hi Andrew,
The only commit I see from you in the net/master branch is the partial fix
I referenced in the 'fixes' line (c21fbe29f858), from all I can tell, my fix is
still needed on top. Can you check again?
Arnd
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] net: dsa: mv88e6xxx: Add missing static to stub functions
2017-05-29 21:06 ` Arnd Bergmann
@ 2017-05-30 16:50 ` Andrew Lunn
0 siblings, 0 replies; 6+ messages in thread
From: Andrew Lunn @ 2017-05-30 16:50 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Vivien Didelot, Florian Fainelli, David S. Miller, Networking,
Linux Kernel Mailing List
On Mon, May 29, 2017 at 11:06:51PM +0200, Arnd Bergmann wrote:
> On Mon, May 29, 2017 at 5:30 PM, Andrew Lunn <andrew@lunn.ch> wrote:
> > On Mon, May 29, 2017 at 02:56:01PM +0200, Arnd Bergmann wrote:
> >> 'static' was not enough, the helpers must be 'static inline'
> >>
> >> net/dsa/mv88e6xxx/global2.h:123:12: error: 'mv88e6xxx_g2_misc_4_bit_port' defined but not used [-Werror=unused-function]
> >> net/dsa/mv88e6xxx/global2.h:117:12: error: 'mv88e6xxx_g2_pvt_write' defined but not used [-Werror=unused-function]
> >>
> >> Fixes: c21fbe29f858 ("net: dsa: mv88e6xxx: Add missing static to stub functions")
> >> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> >
> > Hi Arnd
> >
> > Dave merged my fix yesterday.
>
> Hi Andrew,
>
> The only commit I see from you in the net/master branch is the partial fix
> I referenced in the 'fixes' line (c21fbe29f858), from all I can tell, my fix is
> still needed on top. Can you check again?
Hi Arnd
Yes, you are correct. Adding the static was enough to stop the 0-day
warnings, but they should also inline.
Andrew
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] net: dsa: mv88e6xxx: Add missing static to stub functions
2017-05-29 12:56 [PATCH] net: dsa: mv88e6xxx: Add missing static to stub functions Arnd Bergmann
2017-05-29 15:01 ` Vivien Didelot
2017-05-29 15:30 ` Andrew Lunn
@ 2017-05-30 18:08 ` David Miller
2 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2017-05-30 18:08 UTC (permalink / raw)
To: arnd; +Cc: andrew, vivien.didelot, f.fainelli, netdev, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
Date: Mon, 29 May 2017 14:56:01 +0200
> 'static' was not enough, the helpers must be 'static inline'
>
> net/dsa/mv88e6xxx/global2.h:123:12: error: 'mv88e6xxx_g2_misc_4_bit_port' defined but not used [-Werror=unused-function]
> net/dsa/mv88e6xxx/global2.h:117:12: error: 'mv88e6xxx_g2_pvt_write' defined but not used [-Werror=unused-function]
>
> Fixes: c21fbe29f858 ("net: dsa: mv88e6xxx: Add missing static to stub functions")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-05-30 18:08 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-05-29 12:56 [PATCH] net: dsa: mv88e6xxx: Add missing static to stub functions Arnd Bergmann
2017-05-29 15:01 ` Vivien Didelot
2017-05-29 15:30 ` Andrew Lunn
2017-05-29 21:06 ` Arnd Bergmann
2017-05-30 16:50 ` Andrew Lunn
2017-05-30 18:08 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).