From: Stephen Hemminger <stephen@networkplumber.org>
To: Vladislav Yasevich <vyasevich@gmail.com>
Cc: netdev@vger.kernel.org, dsahern@gmail.com,
roopa@cumulusnetworks.com, jiri@resnulli.us, vfalico@gmail.com,
andy@greyhouse.net, Vladislav Yasevich <vyasevic@redhat.com>
Subject: Re: [PATCH V6 net-next iproute] ip: Add support for netdev events to monitor
Date: Tue, 30 May 2017 10:12:21 -0700 [thread overview]
Message-ID: <20170530101221.1c5cb643@xeon-e3> (raw)
In-Reply-To: <1495894476-9726-4-git-send-email-vyasevic@redhat.com>
On Sat, 27 May 2017 10:14:36 -0400
Vladislav Yasevich <vyasevich@gmail.com> wrote:
>
> +static const char *netdev_events[] = {"NONE",
> + "REBOOT",
> + "FEATURE CHANGE",
> + "BONDING FAILOVER",
> + "NOTIFY PEERS",
> + "RESEND IGMP",
> + "BONDING OPTION"};
Overall this looks fine, I will pickup the if_link.h from net-next.
One stylistic change.
Please add simple line break, and initialize by value:
static const char *netdev_events[] = {
[IFLA_EVENT_NONE] = "NONE",
...
Do you want some prefix or bounding around the event output?
Also a little concerned that the output format change may break some program
could the new output be at the end of the line?
next prev parent reply other threads:[~2017-05-30 17:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-27 14:14 [PATCH V6 net-next 0/2] rtnetlink: Updates to rtnetlink_event() Vladislav Yasevich
2017-05-27 14:14 ` [PATCH V6 net-next 1/2] rtnl: Add support for netdev event to link messages Vladislav Yasevich
2017-05-27 21:41 ` David Ahern
2017-05-27 14:14 ` [PATCH V6 net-next 2/2] bonding: Prevent duplicate userspace notification Vladislav Yasevich
2017-05-27 21:41 ` David Ahern
2017-05-27 14:14 ` [PATCH V6 net-next iproute] ip: Add support for netdev events to monitor Vladislav Yasevich
2017-05-30 14:22 ` David Ahern
2017-05-30 17:12 ` Stephen Hemminger [this message]
2017-05-30 18:26 ` Vlad Yasevich
2017-05-31 20:27 ` Vlad Yasevich
2017-05-27 22:52 ` [PATCH V6 net-next 0/2] rtnetlink: Updates to rtnetlink_event() David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170530101221.1c5cb643@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=andy@greyhouse.net \
--cc=dsahern@gmail.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=roopa@cumulusnetworks.com \
--cc=vfalico@gmail.com \
--cc=vyasevic@redhat.com \
--cc=vyasevich@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).