From: Jiri Benc <jbenc@redhat.com>
To: Roopa Prabhu <roopa@cumulusnetworks.com>
Cc: Mark Bloch <markb@mellanox.com>,
"davem@davemloft.net" <davem@davemloft.net>,
pravin shelar <pshelar@ovn.org>,
Alexander Duyck <aduyck@mirantis.com>,
Nicolas Dichtel <nicolas.dichtel@6wind.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Balki Raman <ramanb@cumulusnetworks.com>
Subject: Re: vxlan: use after free error
Date: Tue, 30 May 2017 13:53:02 +0200 [thread overview]
Message-ID: <20170530135302.5ecaec88@griffin> (raw)
In-Reply-To: <CAJieiUgwRT8NbNdZ37HXJn9OYc78bpj=Zb9N5pQQQ_SLZhD1kg@mail.gmail.com>
On Mon, 29 May 2017 11:37:22 -0700, Roopa Prabhu wrote:
> What you say looks correct..., but does not hurt to leave this check in there..
> given rest of the changes you are proposing below.
I agree with Mark that the check is superfluous and should not be there.
> Looking at git blame, this check was added for OVS in dellink...but it
> could have been because
> it was being called before stop in dellink.
The code at that time did not use rtnl ops to create/delete the tunnel
and was refactored meanwhile. The conditions from that time do not hold
anymore.
> That seems right. It does look redundant if we hit the same code via
> vxlan_stop during dellink.
>
> This code is also hit via the OVS path, and i don't see a problem with
> your changes and analysis but i am not too familiar with the ovs call
> path. I see that the relevant developers are CC'ed.
I think it's okay.
Thanks!
Jiri
prev parent reply other threads:[~2017-05-30 11:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-28 10:49 vxlan: use after free error Mark Bloch
2017-05-29 2:50 ` Roopa Prabhu
2017-05-29 6:28 ` Mark Bloch
2017-05-29 15:32 ` Stephen Hemminger
2017-05-29 18:37 ` Roopa Prabhu
2017-05-30 11:47 ` Jiri Benc
2017-05-30 11:54 ` Jiri Benc
2017-05-30 11:53 ` Jiri Benc [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170530135302.5ecaec88@griffin \
--to=jbenc@redhat.com \
--cc=aduyck@mirantis.com \
--cc=davem@davemloft.net \
--cc=markb@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=pshelar@ovn.org \
--cc=ramanb@cumulusnetworks.com \
--cc=roopa@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).