From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Benc Subject: Re: vxlan: use after free error Date: Tue, 30 May 2017 13:53:02 +0200 Message-ID: <20170530135302.5ecaec88@griffin> References: <03ac7d79-02b7-4bee-d318-9731413bf97b@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Mark Bloch , "davem@davemloft.net" , pravin shelar , Alexander Duyck , Nicolas Dichtel , "netdev@vger.kernel.org" , Balki Raman To: Roopa Prabhu Return-path: Received: from mx1.redhat.com ([209.132.183.28]:53176 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750912AbdE3LxH (ORCPT ); Tue, 30 May 2017 07:53:07 -0400 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On Mon, 29 May 2017 11:37:22 -0700, Roopa Prabhu wrote: > What you say looks correct..., but does not hurt to leave this check in there.. > given rest of the changes you are proposing below. I agree with Mark that the check is superfluous and should not be there. > Looking at git blame, this check was added for OVS in dellink...but it > could have been because > it was being called before stop in dellink. The code at that time did not use rtnl ops to create/delete the tunnel and was refactored meanwhile. The conditions from that time do not hold anymore. > That seems right. It does look redundant if we hit the same code via > vxlan_stop during dellink. > > This code is also hit via the OVS path, and i don't see a problem with > your changes and analysis but i am not too familiar with the ovs call > path. I see that the relevant developers are CC'ed. I think it's okay. Thanks! Jiri