From: Sowmini Varadhan <sowmini.varadhan@oracle.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH RFC net-next] arp: Really delete an arp entry on "arp -d"
Date: Tue, 30 May 2017 19:32:32 -0400 [thread overview]
Message-ID: <20170530233232.GL23089@oracle.com> (raw)
In-Reply-To: <20170530162020.137aef02@xeon-e3>
On (05/30/17 16:20), Stephen Hemminger wrote:
>
> Please don't copy/paste chunks of code. Instead refactor and make this
> into a helper function.
sure, I have no problems with that, and as I pointed out, I've not
tested ipv6 for this yet either. I'll do all of this after getting
some feedback on the more basic issue here:
I was first looking for comments on the more fundamental refcnt
management behind the fix (I'm surprised no one noticed this
before, is there some deep reason for leaving it like this, that
I am missing? Does it break something else?)
And fwiw I was merging pieces of ___neigh_lookup_noref, which figures
out the hash val, and neigh_flush_dev/neigh_forced_gc
next prev parent reply other threads:[~2017-05-30 23:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-30 3:48 [PATCH RFC net-next] arp: Really delete an arp entry on "arp -d" Sowmini Varadhan
2017-05-30 23:20 ` Stephen Hemminger
2017-05-30 23:32 ` Sowmini Varadhan [this message]
2017-05-31 0:42 ` David Ahern
2017-05-31 15:22 ` Sowmini Varadhan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170530233232.GL23089@oracle.com \
--to=sowmini.varadhan@oracle.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).