From: David Miller <davem@davemloft.net>
To: douglascs@taghos.com.br
Cc: netdev@vger.kernel.org, kuznet@ms2.inr.ac.ru, jmorris@namei.org,
yoshfuji@linux-ipv6.org, kaber@trash.net, xemul@parallels.com
Subject: Re: [PATCH] tcp: reinitialize MTU probing when setting MSS in a TCP repair
Date: Wed, 31 May 2017 12:29:48 -0400 (EDT) [thread overview]
Message-ID: <20170531.122948.1070989770678019987.davem@davemloft.net> (raw)
In-Reply-To: <c5033bad-805d-c3f6-3de4-38ab5d3d84e8@taghos.com.br>
From: Douglas Caetano dos Santos <douglascs@taghos.com.br>
Date: Fri, 26 May 2017 14:28:00 -0300
> From: Douglas Caetano dos Santos <douglascs@taghos.com.br>
>
> MTU probing initialization occurred only at connect() and at SYN or
> SYN-ACK reception, but the former sets MSS to either the default or the
> user set value (through TCP_MAXSEG sockopt) and the latter never happens
> with repaired sockets.
>
> The result was that, with MTU probing enabled and unless TCP_MAXSEG
> sockopt was used before connect(), probing would be stuck at
> tcp_base_mss value until tcp_probe_interval seconds have passed.
>
> Signed-off-by: Douglas Caetano dos Santos <douglascs@taghos.com.br>
This seems fine to me, as long as you call tcp_mtup_init() after setting
the mss_clamp, whichy you are, everything should be alright.
Applied, thanks.
prev parent reply other threads:[~2017-05-31 16:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-26 17:28 [PATCH] tcp: reinitialize MTU probing when setting MSS in a TCP repair Douglas Caetano dos Santos
2017-05-31 16:29 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170531.122948.1070989770678019987.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=douglascs@taghos.com.br \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@vger.kernel.org \
--cc=xemul@parallels.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox