* [PATCH net-next] net/mlxfw: select CONFIG_XZ_DEC
@ 2017-05-30 9:26 Arnd Bergmann
2017-05-30 9:28 ` Yotam Gigi
2017-05-31 16:53 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Arnd Bergmann @ 2017-05-30 9:26 UTC (permalink / raw)
To: Yotam Gigi
Cc: Arnd Bergmann, David S. Miller, Ido Schimmel, Jiri Pirko, netdev,
linux-kernel
The new mlxfw code fails to build without the xz library:
drivers/net/ethernet/mellanox/mlxfw/mlxfw_mfa2.o: In function `mlxfw_mfa2_xz_dec_run':
:(.text.mlxfw_mfa2_xz_dec_run+0x8): undefined reference to `xz_dec_run'
drivers/net/ethernet/mellanox/mlxfw/mlxfw_mfa2.o: In function `mlxfw_mfa2_file_component_get':
:(.text.mlxfw_mfa2_file_component_get+0x218): undefined reference to `xz_dec_init'
:(.text.mlxfw_mfa2_file_component_get+0x2c0): undefined reference to `xz_dec_end'
This adds a Kconfig 'select' statement for it, which is also what
the other user of that library has.
Fixes: 410ed13cae39 ("Add the mlxfw module for Mellanox firmware flash process")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/net/ethernet/mellanox/mlxfw/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/mellanox/mlxfw/Kconfig b/drivers/net/ethernet/mellanox/mlxfw/Kconfig
index 56b60ac7bc34..2b21af8a2b1d 100644
--- a/drivers/net/ethernet/mellanox/mlxfw/Kconfig
+++ b/drivers/net/ethernet/mellanox/mlxfw/Kconfig
@@ -4,3 +4,4 @@
config MLXFW
tristate "mlxfw" if COMPILE_TEST
+ select XZ_DEC
--
2.9.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net-next] net/mlxfw: select CONFIG_XZ_DEC
2017-05-30 9:26 [PATCH net-next] net/mlxfw: select CONFIG_XZ_DEC Arnd Bergmann
@ 2017-05-30 9:28 ` Yotam Gigi
2017-05-31 16:53 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Yotam Gigi @ 2017-05-30 9:28 UTC (permalink / raw)
To: Arnd Bergmann
Cc: David S. Miller, Ido Schimmel, Jiri Pirko, netdev, linux-kernel
On 05/30/2017 12:26 PM, Arnd Bergmann wrote:
> The new mlxfw code fails to build without the xz library:
>
> drivers/net/ethernet/mellanox/mlxfw/mlxfw_mfa2.o: In function `mlxfw_mfa2_xz_dec_run':
> :(.text.mlxfw_mfa2_xz_dec_run+0x8): undefined reference to `xz_dec_run'
> drivers/net/ethernet/mellanox/mlxfw/mlxfw_mfa2.o: In function `mlxfw_mfa2_file_component_get':
> :(.text.mlxfw_mfa2_file_component_get+0x218): undefined reference to `xz_dec_init'
> :(.text.mlxfw_mfa2_file_component_get+0x2c0): undefined reference to `xz_dec_end'
>
> This adds a Kconfig 'select' statement for it, which is also what
> the other user of that library has.
>
> Fixes: 410ed13cae39 ("Add the mlxfw module for Mellanox firmware flash process")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/net/ethernet/mellanox/mlxfw/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/mellanox/mlxfw/Kconfig b/drivers/net/ethernet/mellanox/mlxfw/Kconfig
> index 56b60ac7bc34..2b21af8a2b1d 100644
> --- a/drivers/net/ethernet/mellanox/mlxfw/Kconfig
> +++ b/drivers/net/ethernet/mellanox/mlxfw/Kconfig
> @@ -4,3 +4,4 @@
>
> config MLXFW
> tristate "mlxfw" if COMPILE_TEST
> + select XZ_DEC
Thanks!
Acked-by: Yotam Gigi <yotamg@mellanox.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH net-next] net/mlxfw: select CONFIG_XZ_DEC
2017-05-30 9:26 [PATCH net-next] net/mlxfw: select CONFIG_XZ_DEC Arnd Bergmann
2017-05-30 9:28 ` Yotam Gigi
@ 2017-05-31 16:53 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2017-05-31 16:53 UTC (permalink / raw)
To: arnd; +Cc: yotamg, idosch, jiri, netdev, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
Date: Tue, 30 May 2017 11:26:14 +0200
> The new mlxfw code fails to build without the xz library:
>
> drivers/net/ethernet/mellanox/mlxfw/mlxfw_mfa2.o: In function `mlxfw_mfa2_xz_dec_run':
> :(.text.mlxfw_mfa2_xz_dec_run+0x8): undefined reference to `xz_dec_run'
> drivers/net/ethernet/mellanox/mlxfw/mlxfw_mfa2.o: In function `mlxfw_mfa2_file_component_get':
> :(.text.mlxfw_mfa2_file_component_get+0x218): undefined reference to `xz_dec_init'
> :(.text.mlxfw_mfa2_file_component_get+0x2c0): undefined reference to `xz_dec_end'
>
> This adds a Kconfig 'select' statement for it, which is also what
> the other user of that library has.
>
> Fixes: 410ed13cae39 ("Add the mlxfw module for Mellanox firmware flash process")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied, thanks Arnd.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-05-31 16:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-05-30 9:26 [PATCH net-next] net/mlxfw: select CONFIG_XZ_DEC Arnd Bergmann
2017-05-30 9:28 ` Yotam Gigi
2017-05-31 16:53 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).