From: David Miller <davem@davemloft.net>
To: gerlitz.or@gmail.com
Cc: yotamg@mellanox.com, Yuval.Mintz@cavium.com, jiri@resnulli.us,
netdev@vger.kernel.org, idosch@mellanox.com, mlxsw@mellanox.com,
bhutchings@solarflare.com
Subject: Re: [patch net-next 0/9] mlxsw: Support firmware flash
Date: Wed, 31 May 2017 14:18:44 -0400 (EDT) [thread overview]
Message-ID: <20170531.141844.290562274024770237.davem@davemloft.net> (raw)
In-Reply-To: <CAJ3xEMi_U-139_EXfuT+d0PLyBOn6C+aWaGpFfmH6E8odhtvaw@mail.gmail.com>
From: Or Gerlitz <gerlitz.or@gmail.com>
Date: Tue, 30 May 2017 23:32:22 +0300
> On Sun, May 28, 2017 at 10:26 AM, Yotam Gigi <yotamg@mellanox.com> wrote:
>> On 05/23/2017 06:38 PM, David Miller wrote:
>>> From: Yotam Gigi <yotamg@mellanox.com>
>>> Date: Tue, 23 May 2017 18:14:15 +0300
>
>>>> Sorry, I am not sure I understand. You think that drivers should not implement
>>>> ethtool's flash_device callback anymore? do you have an alternative for
>>>> firmware flash?
>
>>> As stated, export an MTD device.
>
>> So, after we have been going over MTD, it seems like it does not fit our needs
>> at all.
>
>> MTD device provides (erasable-)block access to a flash storage, where in our
>> case the firmware burn process is just pouring a binary BLOB into the device.
>> The driver is not aware of the internal storage used for storing the firmware as
>> it is not defined in our driver-hardware API.
>>
>> Needless to say that block access has no meaning in our case, so any solution
>> that will involve MTD device to burn our firmware (if there is a solution at
>> all) will be a workaround and will not fit MTD purpose.
>>
>> Apart for boot time firmware flash, which we have already pushed we would really
>> like to allow the user to ask for a specific firmware version. Do you have any
>> other solution for us apart from "ethtool -f"?
>>
>> This problem is even more relevant in the Mellanox HCA driver team, which would
>> like to use that code in order to burn the HCA firmware, but not intend to
>> trigger it on boot time, which means that must have a way for the user to
>> trigger it.
>
>
> Hi Dave,
>
> We had few more emails on this thread with Jakub, and he's now happy
> with our replies, so where do we go from here? could you comment on
> Yotam's note.
Ok, use ethtool -f if you must.
prev parent reply other threads:[~2017-05-31 18:18 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-23 6:52 [patch net-next 0/9] mlxsw: Support firmware flash Jiri Pirko
2017-05-23 6:52 ` [patch net-next 1/9] Add the mlxfw module for Mellanox firmware flash process Jiri Pirko
2017-05-23 6:52 ` [patch net-next 2/9] mlxsw: reg: Add Management Component Query Information register Jiri Pirko
2017-05-23 6:52 ` [patch net-next 3/9] mlxsw: reg: Add Management Component Control register Jiri Pirko
2017-05-23 6:52 ` [patch net-next 4/9] mlxsw: reg: Add Management Component Data Access register Jiri Pirko
2017-05-23 6:52 ` [patch net-next 5/9] mlxsw: spectrum: Add the needed callbacks for mlxfw integration Jiri Pirko
2017-05-23 6:52 ` [patch net-next 6/9] mlxsw: spectrum: Implement the ethtool flash_device callback Jiri Pirko
2017-05-23 6:52 ` [patch net-next 7/9] mlxsw: core: Create the mlxsw_fw_rev struct Jiri Pirko
2017-05-23 6:53 ` [patch net-next 8/9] mlxsw: spectrum: Validate firmware revision on init Jiri Pirko
2017-05-23 6:53 ` [patch net-next 9/9] mlxsw: spectrum_router: Adjust RIF configuration for new firmware versions Jiri Pirko
2017-05-23 13:18 ` [patch net-next 0/9] mlxsw: Support firmware flash Mintz, Yuval
2017-05-23 14:37 ` Yotam Gigi
2017-05-23 15:04 ` Mintz, Yuval
2017-05-23 15:14 ` Yotam Gigi
2017-05-23 15:19 ` Mintz, Yuval
2017-05-23 15:38 ` David Miller
2017-05-23 15:52 ` Jiri Pirko
2017-05-28 7:26 ` Yotam Gigi
2017-05-29 0:17 ` Jakub Kicinski
2017-05-29 8:33 ` Yotam Gigi
2017-05-29 8:52 ` Or Gerlitz
2017-05-29 21:40 ` Jakub Kicinski
2017-05-30 20:32 ` Or Gerlitz
2017-05-31 18:18 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170531.141844.290562274024770237.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Yuval.Mintz@cavium.com \
--cc=bhutchings@solarflare.com \
--cc=gerlitz.or@gmail.com \
--cc=idosch@mellanox.com \
--cc=jiri@resnulli.us \
--cc=mlxsw@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=yotamg@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).