From: David Miller <davem@davemloft.net>
To: baijiaju1990@163.com
Cc: isdn@linux-pingi.de, geliangtang@gmail.com,
keescook@chromium.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] isdn: Fix a sleep-in-atomic bug
Date: Wed, 31 May 2017 14:38:46 -0400 (EDT) [thread overview]
Message-ID: <20170531.143846.1683078095046995517.davem@davemloft.net> (raw)
In-Reply-To: <1496194811-32297-1-git-send-email-baijiaju1990@163.com>
From: Jia-Ju Bai <baijiaju1990@163.com>
Date: Wed, 31 May 2017 09:40:11 +0800
> The driver may sleep under a spin lock, the function call path is:
> isdn_ppp_mp_receive (acquire the lock)
> isdn_ppp_mp_reassembly
> isdn_ppp_push_higher
> isdn_ppp_decompress
> isdn_ppp_ccp_reset_trans
> isdn_ppp_ccp_reset_alloc_state
> kzalloc(GFP_KERNEL) --> may sleep
>
> To fixed it, the "GFP_KERNEL" is replaced with "GFP_ATOMIC".
>
> Signed-off-by: Jia-Ju Bai <baijiaju1990@163.com>
Applied.
prev parent reply other threads:[~2017-05-31 18:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-31 1:40 [PATCH] isdn: Fix a sleep-in-atomic bug Jia-Ju Bai
2017-05-31 18:38 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170531.143846.1683078095046995517.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=baijiaju1990@163.com \
--cc=geliangtang@gmail.com \
--cc=isdn@linux-pingi.de \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox