From: Stephen Hemminger <stephen@networkplumber.org>
To: Alexander Potapenko <glider@google.com>
Cc: dvyukov@google.com, kcc@google.com, edumazet@google.com,
davem@davemloft.net, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH v2] net: don't call strlen on non-terminated string in dev_set_alias()
Date: Wed, 31 May 2017 08:37:06 -0700 [thread overview]
Message-ID: <20170531083706.1baa729f@xeon-e3> (raw)
In-Reply-To: <20170531125150.28798-1-glider@google.com>
On Wed, 31 May 2017 14:51:50 +0200
Alexander Potapenko <glider@google.com> wrote:
> + /* alias comes from the userspace and may not be zero-terminated.
> + */
> + memcpy(dev->ifalias, alias, len);
You don't need a multi-line comment here.
prev parent reply other threads:[~2017-05-31 15:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-31 12:51 [PATCH v2] net: don't call strlen on non-terminated string in dev_set_alias() Alexander Potapenko
2017-05-31 15:37 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170531083706.1baa729f@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=davem@davemloft.net \
--cc=dvyukov@google.com \
--cc=edumazet@google.com \
--cc=glider@google.com \
--cc=kcc@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).