netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jiri Benc <jbenc@redhat.com>
To: Jiri Pirko <jiri@resnulli.us>
Cc: netdev@vger.kernel.org, davem@davemloft.net, jhs@mojatatu.com,
	xiyou.wangcong@gmail.com, dsa@cumulusnetworks.com,
	edumazet@google.com, stephen@networkplumber.org,
	daniel@iogearbox.net, alexander.h.duyck@intel.com,
	simon.horman@netronome.com, mlxsw@mellanox.com
Subject: Re: [patch iproute2 v2 repost 3/3] tc/actions: introduce support for goto chain action
Date: Wed, 31 May 2017 14:27:02 +0200	[thread overview]
Message-ID: <20170531142702.6d0ca6fa@griffin> (raw)
In-Reply-To: <20170516172937.1391-3-jiri@resnulli.us>

On Tue, 16 May 2017 19:29:37 +0200, Jiri Pirko wrote:
> From: Jiri Pirko <jiri@mellanox.com>
> 
> Allow user to set control action "goto" with filter chain index as
> a parameter.
> 
> Signed-off-by: Jiri Pirko <jiri@mellanox.com>
> ---
>  include/linux/pkt_cls.h | 16 +++++++++++++++-
>  man/man8/tc-ife.8       |  2 +-
>  man/man8/tc-pedit.8     |  2 +-
>  man/man8/tc-police.8    |  2 +-
>  man/man8/tc-vlan.8      |  2 +-

Jiri, this *seriously* needs a proper documentation. I consider myself
to be well above average in understanding tc filters and actions, and as
you know I participated at least passively in some chats about the
chains. Yet I'm still very lost in semantics of chains. I cannot
imagine how an average user would be able to use this.

Some questions about the semantics:

- What chain(s) are processed by default? If I don't use goto_chain but
  have multiple chains, will only chain 0 be processed, or more? In
  what order, what are the rules? If I don't have a chain 0, what would
  happen?

- What is the relation between priorities and chains? I expected that
  chains are under the same priority but that's not the case in your
  example. For a user, it's very unclear why there are priorities and
  chains. They appear to do the same thing, why can't I just jump
  between priorities?

Please, in addition to explaining here on the list, add detailed
explanation to the man pages.

Thanks,

 Jiri

  reply	other threads:[~2017-05-31 12:27 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-16 17:27 [patch net-next v3 00/10] net: sched: introduce multichain support for filters Jiri Pirko
2017-05-16 17:27 ` [patch net-next v3 01/10] net: sched: move tc_classify function to cls_api.c Jiri Pirko
2017-05-16 20:25   ` Cong Wang
2017-05-16 21:00     ` Jiri Pirko
2017-05-16 21:03       ` Cong Wang
2017-05-16 21:05         ` Jiri Pirko
2017-05-16 17:27 ` [patch net-next v3 02/10] net: sched: introduce tcf block infractructure Jiri Pirko
2017-05-16 20:51   ` Cong Wang
2017-05-16 20:57     ` Jiri Pirko
2017-05-16 21:34     ` David Miller
2017-05-16 22:34       ` Cong Wang
2017-05-17  5:42         ` Jiri Pirko
2017-05-16 17:27 ` [patch net-next v3 03/10] net: sched: rename tcf_destroy_chain helper Jiri Pirko
2017-05-16 17:27 ` [patch net-next v3 04/10] net: sched: replace nprio by a bool to make the function more readable Jiri Pirko
2017-05-16 17:27 ` [patch net-next v3 05/10] net: sched: move TC_H_MAJ macro call into tcf_auto_prio Jiri Pirko
2017-05-16 21:01   ` Cong Wang
2017-05-16 21:03     ` Jiri Pirko
2017-05-16 22:38       ` Cong Wang
2017-05-17  5:47         ` Jiri Pirko
2017-05-17 12:47           ` Jamal Hadi Salim
2017-05-17 12:53             ` Jiri Pirko
2017-05-16 17:27 ` [patch net-next v3 06/10] net: sched: introduce helpers to work with filter chains Jiri Pirko
2017-05-16 22:17   ` Cong Wang
2017-05-17  5:50     ` Jiri Pirko
2017-05-16 17:27 ` [patch net-next v3 07/10] net: sched: push chain dump to a separate function Jiri Pirko
2017-05-16 17:28 ` [patch net-next v3 08/10] net: sched: introduce multichain support for filters Jiri Pirko
2017-05-16 17:28 ` [patch net-next v3 09/10] net: sched: push tp down to action init Jiri Pirko
2017-05-16 17:28 ` [patch net-next v3 10/10] net: sched: add termination action to allow goto chain Jiri Pirko
2017-05-16 17:29 ` [patch iproute2 v2 repost 1/3] tc_filter: add support for chain index Jiri Pirko
2017-05-16 18:16   ` Stephen Hemminger
2017-05-16 19:47     ` Jiri Pirko
2017-05-22 20:33   ` Stephen Hemminger
2017-05-23 13:40     ` Jiri Pirko
2017-05-26 19:48       ` Daniel Borkmann
2017-05-27  0:11         ` Stephen Hemminger
2017-05-27  0:24           ` Daniel Borkmann
2017-05-16 17:29 ` [patch iproute2 v2 repost 2/3] tc: actions: add helpers to parse and print control actions Jiri Pirko
2017-06-14 18:32   ` Jiri Benc
2017-06-14 19:18     ` Jiri Pirko
2017-06-14 19:28       ` Jiri Benc
2017-06-14 20:10         ` Jiri Pirko
2017-05-16 17:29 ` [patch iproute2 v2 repost 3/3] tc/actions: introduce support for goto chain action Jiri Pirko
2017-05-31 12:27   ` Jiri Benc [this message]
2017-06-02  8:15     ` Jiri Pirko
2017-06-02  8:22       ` Jiri Benc

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170531142702.6d0ca6fa@griffin \
    --to=jbenc@redhat.com \
    --cc=alexander.h.duyck@intel.com \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=dsa@cumulusnetworks.com \
    --cc=edumazet@google.com \
    --cc=jhs@mojatatu.com \
    --cc=jiri@resnulli.us \
    --cc=mlxsw@mellanox.com \
    --cc=netdev@vger.kernel.org \
    --cc=simon.horman@netronome.com \
    --cc=stephen@networkplumber.org \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).