From: Andrew Lunn <andrew@lunn.ch>
To: David Miller <davem@davemloft.net>
Cc: Woojung.Huh@microchip.com, f.fainelli@gmail.com,
netdev@vger.kernel.org, UNGLinuxDriver@microchip.com
Subject: Re: [PATCH v5 net-next 0/5] dsa: add Microchip KSZ9477 DSA driver
Date: Wed, 31 May 2017 20:52:05 +0200 [thread overview]
Message-ID: <20170531185205.GC11230@lunn.ch> (raw)
In-Reply-To: <20170531.144732.768135527494752476.davem@davemloft.net>
On Wed, May 31, 2017 at 02:47:32PM -0400, David Miller wrote:
> From: David Miller <davem@davemloft.net>
> Date: Wed, 31 May 2017 14:28:30 -0400 (EDT)
>
> > From: <Woojung.Huh@microchip.com>
> > Date: Wed, 31 May 2017 00:00:34 +0000
> >
> >> From: Woojung Huh <Woojung.Huh@microchip.com>
> >>
> >> This series of patches is for Microchip KSZ9477 DSA driver.
> >> KSZ9477 is 7 ports GigE switch with numerous advanced features.
> >> 5 ports are 10/100/1000 Mbps internal PHYs and 2 ports have
> >> Interfaces to SGMII, RGMII, MII or RMII.
> >>
> >> This patch supports VLAN, MDB, FDB and port mirroring offloads.
> >>
> >> Welcome reviews and comments from community.
> >>
> >> Note: Tests are performed on internal development board.
> >
> > Series applied, thanks.
>
> Unfortunately, I had to revert, you didn't add MODULE_LICENSE() tags
> to the new drivers.
>
> WARNING: modpost: missing MODULE_LICENSE() in drivers/net/dsa/microchip/ksz_common.o
> see include/linux/module.h for more information
> WARNING: modpost: missing MODULE_LICENSE() in drivers/net/dsa/microchip/ksz_spi.o
> see include/linux/module.h for more information
Hi Woojung
Humm, it does not mention the GPL in any of the file headers. So it is
unclear to me what license is used on these files.
Andrew
next prev parent reply other threads:[~2017-05-31 18:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-31 0:00 [PATCH v5 net-next 0/5] dsa: add Microchip KSZ9477 DSA driver Woojung.Huh
2017-05-31 18:28 ` David Miller
2017-05-31 18:47 ` David Miller
2017-05-31 18:52 ` Andrew Lunn [this message]
2017-05-31 18:56 ` Woojung.Huh
-- strict thread matches above, loose matches on Subject: below --
2017-05-31 20:19 Woojung.Huh
2017-06-01 0:57 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170531185205.GC11230@lunn.ch \
--to=andrew@lunn.ch \
--cc=UNGLinuxDriver@microchip.com \
--cc=Woojung.Huh@microchip.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox