From: David Miller <davem@davemloft.net>
To: Yuval.Mintz@cavium.com
Cc: netdev@vger.kernel.org, eric.dumazet@gmail.com
Subject: Re: [PATCH net] bnx2x: Fix Multi-Cos
Date: Thu, 01 Jun 2017 12:22:59 -0400 (EDT) [thread overview]
Message-ID: <20170601.122259.945935496179490442.davem@davemloft.net> (raw)
In-Reply-To: <20170601125756.25019-1-Yuval.Mintz@cavium.com>
From: Yuval Mintz <Yuval.Mintz@cavium.com>
Date: Thu, 1 Jun 2017 15:57:56 +0300
> Apparently multi-cos isn't working for bnx2x quite some time -
> driver implements ndo_select_queue() to allow queue-selection
> for FCoE, but the regular L2 flow would cause it to modulo the
> fallback's result by the number of queues.
> The fallback would return a queue matching the needed tc
> [via __skb_tx_hash()], but since the modulo is by the number of TSS
> queues where number of TCs is not accounted, transmission would always
> be done by a queue configured into using TC0.
>
> Fixes: ada7c19e6d27 ("bnx2x: use XPS if possible for bnx2x_select_queue instead of pure hash")
> Signed-off-by: Yuval Mintz <Yuval.Mintz@cavium.com>
Applied and queued up for -stable.
prev parent reply other threads:[~2017-06-01 16:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-01 12:57 [PATCH net] bnx2x: Fix Multi-Cos Yuval Mintz
2017-06-01 16:22 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170601.122259.945935496179490442.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Yuval.Mintz@cavium.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).