From: David Miller <davem@davemloft.net>
To: leonard.crestez@nxp.com
Cc: f.fainelli@gmail.com, andrew@lunn.ch, shawnguo@kernel.org,
fugang.duan@nxp.com, johan@kernel.org,
alexandre.belloni@free-electrons.com, p.zabel@pengutronix.de,
fabio.estevam@nxp.com, netdev@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/2] ARM: imx6ul-14x14-evk: Fix suspend over nfs by phy
Date: Thu, 01 Jun 2017 15:03:20 -0400 (EDT) [thread overview]
Message-ID: <20170601.150320.128443002523337995.davem@davemloft.net> (raw)
In-Reply-To: <cover.1496224930.git.leonard.crestez@nxp.com>
From: Leonard Crestez <leonard.crestez@nxp.com>
Date: Wed, 31 May 2017 13:29:28 +0300
> Right now attempting doing suspend/resume while root is mounted over NFS
> hangs on imx6ul-14x14-evk. This is happening because ksz8081 phy fixups are
> lost on resume.
>
> Fix this by using equivalent devicetree properties instead of a phy fixup
> and handling those properties on resume in the micrel driver.
>
> In theory it might now be possible to remove the phy fixup from mach-imx6ul
> entirely but it is possible that this would break other imx6ul boards which
> use the same phy. The solution would be to patch their dts but it's not
> clear how to identify affected boards.
>
> This code is shared with imx6ull-14x14-evk but 6ull suspend needs an
> unrelated patch: https://lkml.org/lkml/2017/5/30/584
>
> This is something of a corner case so there is no CC: stable.
>
> Changes since v1: https://lkml.org/lkml/2017/5/30/672
> * Split a kszphy_config_reset function for stuff shared between
> config_init and resume. Calling config_init directly could be an option but
> on some HW variants it does extra stuff like parsing devicetree options.
> That would not be appropriate for resume code.
Series applied.
prev parent reply other threads:[~2017-06-01 19:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-31 10:29 [PATCH v2 0/2] ARM: imx6ul-14x14-evk: Fix suspend over nfs by phy Leonard Crestez
2017-05-31 10:29 ` [PATCH v2 1/2] ARM: dts: imx6ul-14x14-evk: Add ksz8081 phy properties Leonard Crestez
2017-05-31 21:52 ` Florian Fainelli
2017-05-31 10:29 ` [PATCH v2 net 2/2] net: phy: micrel: Restore led_mode and clk_sel on resume Leonard Crestez
2017-05-31 21:52 ` Florian Fainelli
2017-06-01 19:03 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170601.150320.128443002523337995.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alexandre.belloni@free-electrons.com \
--cc=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=fabio.estevam@nxp.com \
--cc=fugang.duan@nxp.com \
--cc=johan@kernel.org \
--cc=leonard.crestez@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).