From: David Miller <davem@davemloft.net>
To: idosch@mellanox.com
Cc: netdev@vger.kernel.org, jiri@mellanox.com,
nikolay@cumulusnetworks.com, mlxsw@mellanox.com, arnd@arndb.de
Subject: Re: [PATCH net-next] mlxsw: spectrum: Add bridge dependency for spectrum
Date: Thu, 01 Jun 2017 15:07:00 -0400 (EDT) [thread overview]
Message-ID: <20170601.150700.1560422855112281074.davem@davemloft.net> (raw)
In-Reply-To: <20170531183342.19349-1-idosch@mellanox.com>
From: Ido Schimmel <idosch@mellanox.com>
Date: Wed, 31 May 2017 21:33:42 +0300
> When BRIDGE is a loadable module, MLXSW_SPECTRUM mustn't be built-in:
>
> drivers/built-in.o: In function `mlxsw_sp_bridge_device_create':
> drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c:145: undefined reference to `br_vlan_enabled'
> drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c:158: undefined reference to `br_multicast_enabled'
> drivers/built-in.o: In function `mlxsw_sp_dev_rif_type':
> drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c:2972: undefined reference to `br_vlan_enabled'
> drivers/built-in.o: In function `mlxsw_sp_inetaddr_vlan_event':
> drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c:3310: undefined reference to `br_vlan_enabled'
>
> Add Kconfig dependency to enforce usable configurations.
>
> Fixes: c57529e1d5d8 ("mlxsw: spectrum: Replace vPorts with Port-VLAN")
> Signed-off-by: Ido Schimmel <idosch@mellanox.com>
> Reported-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
> Tested-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Applied, thanks.
prev parent reply other threads:[~2017-06-01 19:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-31 18:33 [PATCH net-next] mlxsw: spectrum: Add bridge dependency for spectrum Ido Schimmel
2017-06-01 19:07 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170601.150700.1560422855112281074.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=arnd@arndb.de \
--cc=idosch@mellanox.com \
--cc=jiri@mellanox.com \
--cc=mlxsw@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox