* [PATCH][net-next] qtnfmac: remove duplicated assignment to mac
@ 2017-05-25 13:45 Colin King
2017-05-25 13:56 ` Sergey Matyukevich
2017-06-01 9:50 ` [net-next] " Kalle Valo
0 siblings, 2 replies; 3+ messages in thread
From: Colin King @ 2017-05-25 13:45 UTC (permalink / raw)
To: Avinash Patil, Sergey Matyukevich, Kalle Valo, Huizhao Wang,
Kamlesh Rath, linux-wireless, netdev
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
mac is being assigned twice, remove redundant 2nd assignment.
Detected by CoverityScan, CID#1437554 ("Incorrect expression")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/net/wireless/quantenna/qtnfmac/cfg80211.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/quantenna/qtnfmac/cfg80211.c b/drivers/net/wireless/quantenna/qtnfmac/cfg80211.c
index fc0ce2c09097..e3c090008125 100644
--- a/drivers/net/wireless/quantenna/qtnfmac/cfg80211.c
+++ b/drivers/net/wireless/quantenna/qtnfmac/cfg80211.c
@@ -922,7 +922,7 @@ void qtnf_netdev_updown(struct net_device *ndev, bool up)
void qtnf_virtual_intf_cleanup(struct net_device *ndev)
{
struct qtnf_vif *vif = qtnf_netdev_get_priv(ndev);
- struct qtnf_wmac *mac = mac = wiphy_priv(vif->wdev.wiphy);
+ struct qtnf_wmac *mac = wiphy_priv(vif->wdev.wiphy);
if (vif->wdev.iftype == NL80211_IFTYPE_STATION) {
switch (vif->sta_state) {
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH][net-next] qtnfmac: remove duplicated assignment to mac
2017-05-25 13:45 [PATCH][net-next] qtnfmac: remove duplicated assignment to mac Colin King
@ 2017-05-25 13:56 ` Sergey Matyukevich
2017-06-01 9:50 ` [net-next] " Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Sergey Matyukevich @ 2017-05-25 13:56 UTC (permalink / raw)
To: Colin King
Cc: Avinash Patil, Sergey Matyukevich, Igor Mitsyanko, Kalle Valo,
Huizhao Wang, Kamlesh Rath, linux-wireless, netdev,
kernel-janitors, linux-kernel
> mac is being assigned twice, remove redundant 2nd assignment.
>
> Detected by CoverityScan, CID#1437554 ("Incorrect expression")
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/net/wireless/quantenna/qtnfmac/cfg80211.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/quantenna/qtnfmac/cfg80211.c b/drivers/net/wireless/quantenna/qtnfmac/cfg80211.c
> index fc0ce2c09097..e3c090008125 100644
> --- a/drivers/net/wireless/quantenna/qtnfmac/cfg80211.c
> +++ b/drivers/net/wireless/quantenna/qtnfmac/cfg80211.c
> @@ -922,7 +922,7 @@ void qtnf_netdev_updown(struct net_device *ndev, bool up)
> void qtnf_virtual_intf_cleanup(struct net_device *ndev)
> {
> struct qtnf_vif *vif = qtnf_netdev_get_priv(ndev);
> - struct qtnf_wmac *mac = mac = wiphy_priv(vif->wdev.wiphy);
> + struct qtnf_wmac *mac = wiphy_priv(vif->wdev.wiphy);
Thanks !
Acked-by: Sergey Matyukevich <sergey.matyukevich.os@quantenna.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [net-next] qtnfmac: remove duplicated assignment to mac
2017-05-25 13:45 [PATCH][net-next] qtnfmac: remove duplicated assignment to mac Colin King
2017-05-25 13:56 ` Sergey Matyukevich
@ 2017-06-01 9:50 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2017-06-01 9:50 UTC (permalink / raw)
To: Colin Ian King
Cc: Avinash Patil, Sergey Matyukevich, Huizhao Wang, Kamlesh Rath,
linux-wireless, netdev, kernel-janitors, linux-kernel
Colin Ian King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> mac is being assigned twice, remove redundant 2nd assignment.
>
> Detected by CoverityScan, CID#1437554 ("Incorrect expression")
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> Acked-by: Sergey Matyukevich <sergey.matyukevich.os@quantenna.com>
Patch applied to wireless-drivers-next.git, thanks.
4f8e25458cb6 qtnfmac: remove duplicated assignment to mac
--
https://patchwork.kernel.org/patch/9748407/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-06-01 9:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-05-25 13:45 [PATCH][net-next] qtnfmac: remove duplicated assignment to mac Colin King
2017-05-25 13:56 ` Sergey Matyukevich
2017-06-01 9:50 ` [net-next] " Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).