From: Jonathan Corbet <corbet@lwn.net>
To: Jia-Ju Bai <baijiaju1990@163.com>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
kvalo@codeaurora.org, linux-wireless@vger.kernel.org,
b43-dev@lists.infradead.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] b43legacy: Fix a sleep-in-atomic bug in b43legacy_attr_interfmode_store
Date: Thu, 1 Jun 2017 10:11:13 -0600 [thread overview]
Message-ID: <20170601101113.6dd30d6d@lwn.net> (raw)
In-Reply-To: <592F6843.9000204@163.com>
On Thu, 01 Jun 2017 09:05:07 +0800
Jia-Ju Bai <baijiaju1990@163.com> wrote:
> I admit my patches are not well tested, and they may not well fix the bugs.
> I am looking forward to opinions and suggestions :)
May I politely suggest that sending out untested locking changes is a
dangerous thing to do? You really should not be changing the locking in a
piece of kernel code without understanding very well what the lock is
protecting and being able to say why your changes are safe. Without that,
the risk of introducing subtle bugs is very high.
It looks like you have written a useful tool that could help us to make
the kernel more robust. If you are interested in my suggestion, I would
recommend that you post the sleep-in-atomic scenarios that you are
finding, but refrain from "fixing" them in any case where you cannot offer
a strong explanation of why your fix is correct.
Thanks for working to find bugs in the kernel!
jon
next prev parent reply other threads:[~2017-06-01 16:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-31 10:29 [PATCH] b43legacy: Fix a sleep-in-atomic bug in b43legacy_attr_interfmode_store Jia-Ju Bai
2017-05-31 15:17 ` Michael Büsch
2017-05-31 17:33 ` Larry Finger
[not found] ` <85905124-7167-aeb0-8aff-4ceec09e9542-tQ5ms3gMjBLk1uMJSBkQmQ@public.gmane.org>
2017-06-01 1:05 ` Jia-Ju Bai
[not found] ` <592F6843.9000204-9Onoh4P/yGk@public.gmane.org>
2017-06-01 4:15 ` Kalle Valo
2017-06-01 16:11 ` Jonathan Corbet [this message]
2017-06-01 17:43 ` Larry Finger
[not found] ` <20170601101113.6dd30d6d-T1hC0tSOHrs@public.gmane.org>
2017-06-02 1:18 ` Jia-Ju Bai
[not found] ` <5930BCD6.9010306-9Onoh4P/yGk@public.gmane.org>
2017-07-30 10:24 ` Michael Büsch
2017-06-01 23:24 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170601101113.6dd30d6d@lwn.net \
--to=corbet@lwn.net \
--cc=Larry.Finger@lwfinger.net \
--cc=b43-dev@lists.infradead.org \
--cc=baijiaju1990@163.com \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).