From: Cyril Hrubis <chrubis@suse.cz>
To: Soheil Hassas Yeganeh <soheil@google.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Shmulik Ladkani <shmulik.ladkani@gmail.com>,
Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>,
Pravin B Shelar <pshelar@ovn.org>,
Eric Dumazet <edumazet@google.com>,
WANG Cong <xiyou.wangcong@gmail.com>,
Yaogong Wang <wygivan@google.com>,
Steffen Klassert <steffen.klassert@secunet.com>,
Al Viro <viro@zeniv.linux.org.uk>,
netdev <netdev@vger.kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: commit f5f99309 (sock: do not set sk_err in sock_dequeue_err_skb) has broken ping
Date: Thu, 1 Jun 2017 22:03:14 +0200 [thread overview]
Message-ID: <20170601200314.GD10526@rei.suse.de> (raw)
In-Reply-To: <CACSApvb_CtFEenaSGcpUk6yb8O3X95MAULkJ-+T1hscCE_O_jg@mail.gmail.com>
Hi!
> Thank you very much! I have a wild guess that, when we
> have a train of skbs on the error queue starting from a local error,
> we will see this issue.
>
> Ping (without my patch) considers EAGAIN on a normal read as an
> indication that there is nothing on the error queue, but that's a
> flawed assumption.
>
> Would you mind trying another shot in the darkness please? Thanks!
This patch seems to fix the issue, I've tried several times and poll()
just timeouts, haven't seen a single POLLERR in the ping strace.
You can add my Tested-by: for this patch as well :-).
--
Cyril Hrubis
chrubis@suse.cz
prev parent reply other threads:[~2017-06-01 20:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-01 14:00 commit f5f99309 (sock: do not set sk_err in sock_dequeue_err_skb) has broken ping Cyril Hrubis
2017-06-01 14:10 ` Soheil Hassas Yeganeh
2017-06-01 14:31 ` Cyril Hrubis
2017-06-01 14:39 ` Soheil Hassas Yeganeh
2017-06-01 15:10 ` Cyril Hrubis
2017-06-01 15:15 ` Soheil Hassas Yeganeh
2017-06-01 15:36 ` Cyril Hrubis
2017-06-01 16:42 ` Soheil Hassas Yeganeh
2017-06-01 20:03 ` Cyril Hrubis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170601200314.GD10526@rei.suse.de \
--to=chrubis@suse.cz \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.leitner@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pshelar@ovn.org \
--cc=shmulik.ladkani@gmail.com \
--cc=soheil@google.com \
--cc=steffen.klassert@secunet.com \
--cc=viro@zeniv.linux.org.uk \
--cc=wygivan@google.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).