From: Yuval Mintz <Yuval.Mintz@cavium.com>
To: <netdev@vger.kernel.org>, <davem@davemloft.net>
Cc: <linux-scsi@vger.kernel.org>, <nilesh.javali@cavium.com>,
<chad.dupuis@cavium.com>, <saurav.kashyap@cavium.com>,
Yuval Mintz <Yuval.Mintz@cavium.com>
Subject: [PATCH net-next 1/4] qed: Correct order of wwnn and wwpn
Date: Fri, 2 Jun 2017 08:58:30 +0300 [thread overview]
Message-ID: <20170602055833.21814-2-Yuval.Mintz@cavium.com> (raw)
In-Reply-To: <20170602055833.21814-1-Yuval.Mintz@cavium.com>
Driver reads values via HSI splitting this 8-byte into 2 32-bit
values and builds a single u64 field - but it does so by shifting
the lower field instead of the higher.
Luckily, we still don't use these fields for anything - but we're about
to start.
Signed-off-by: Yuval Mintz <Yuval.Mintz@cavium.com>
---
drivers/net/ethernet/qlogic/qed/qed_mcp.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/qlogic/qed/qed_mcp.c b/drivers/net/ethernet/qlogic/qed/qed_mcp.c
index 31c88e1..e82f329 100644
--- a/drivers/net/ethernet/qlogic/qed/qed_mcp.c
+++ b/drivers/net/ethernet/qlogic/qed/qed_mcp.c
@@ -1736,10 +1736,10 @@ int qed_mcp_fill_shmem_func_info(struct qed_hwfn *p_hwfn,
DP_NOTICE(p_hwfn, "MAC is 0 in shmem\n");
}
- info->wwn_port = (u64)shmem_info.fcoe_wwn_port_name_upper |
- (((u64)shmem_info.fcoe_wwn_port_name_lower) << 32);
- info->wwn_node = (u64)shmem_info.fcoe_wwn_node_name_upper |
- (((u64)shmem_info.fcoe_wwn_node_name_lower) << 32);
+ info->wwn_port = (u64)shmem_info.fcoe_wwn_port_name_lower |
+ (((u64)shmem_info.fcoe_wwn_port_name_upper) << 32);
+ info->wwn_node = (u64)shmem_info.fcoe_wwn_node_name_lower |
+ (((u64)shmem_info.fcoe_wwn_node_name_upper) << 32);
info->ovlan = (u16)(shmem_info.ovlan_stag & FUNC_MF_CFG_OV_STAG_MASK);
--
2.9.4
next prev parent reply other threads:[~2017-06-02 5:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-02 5:58 [PATCH net-next 0/4] qed: Enhance storage APIs Yuval Mintz
2017-06-02 5:58 ` Yuval Mintz [this message]
2017-06-02 5:58 ` [PATCH net-next 2/4] qed: Share additional information with qedf Yuval Mintz
2017-06-02 5:58 ` [PATCH net-next 3/4] qed: Support NVM-image reading API Yuval Mintz
2017-06-02 5:58 ` [PATCH net-next 4/4] qed: Add support for changing iSCSI mac Yuval Mintz
2017-06-02 14:36 ` [PATCH net-next 0/4] qed: Enhance storage APIs David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170602055833.21814-2-Yuval.Mintz@cavium.com \
--to=yuval.mintz@cavium.com \
--cc=chad.dupuis@cavium.com \
--cc=davem@davemloft.net \
--cc=linux-scsi@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nilesh.javali@cavium.com \
--cc=saurav.kashyap@cavium.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox