From: kbuild test robot <lkp@intel.com>
To: Paul Burton <paul.burton@imgtec.com>
Cc: kbuild-all@01.org, netdev@vger.kernel.org,
Tobias Klauser <tklauser@distanz.ch>,
"David S . Miller" <davem@davemloft.net>,
Jarod Wilson <jarod@redhat.com>,
linux-mips@linux-mips.org, Eric Dumazet <edumazet@google.com>,
Paul Burton <paul.burton@imgtec.com>
Subject: [PATCH] net: pch_gbe: fix err_cast.cocci warnings
Date: Sat, 3 Jun 2017 14:36:42 +0800 [thread overview]
Message-ID: <20170603063642.GA10389@lkp-wsm-ep2> (raw)
In-Reply-To: <20170602234042.22782-5-paul.burton@imgtec.com>
drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c:2587:9-16: WARNING: ERR_CAST can be used with gpio
Use ERR_CAST inlined function instead of ERR_PTR(PTR_ERR(...))
Generated by: scripts/coccinelle/api/err_cast.cocci
CC: Paul Burton <paul.burton@imgtec.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
pch_gbe_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c
+++ b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c
@@ -2584,7 +2584,7 @@ pch_gbe_get_priv(struct pci_dev *pdev, c
if (!IS_ERR(gpio))
pdata->phy_reset_gpio = gpio;
else if (PTR_ERR(gpio) != -ENOENT)
- return ERR_PTR(PTR_ERR(gpio));
+ return ERR_CAST(gpio);
return pdata;
}
next prev parent reply other threads:[~2017-06-03 6:36 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-02 23:40 [PATCH v3 0/7] net: pch_gbe: Fixes & MIPS support Paul Burton
2017-06-02 23:40 ` [PATCH v3 1/7] net: pch_gbe: Mark Minnow PHY reset GPIO active low Paul Burton
2017-06-02 23:40 ` [PATCH v3 2/7] net: pch_gbe: Pull PHY GPIO handling out of Minnow code Paul Burton
2017-06-03 17:52 ` Andrew Lunn
2017-06-05 17:21 ` Paul Burton
2017-06-05 18:43 ` Andrew Lunn
[not found] ` <20170602234042.22782-1-paul.burton-1AXoQHu6uovQT0dZR+AlfA@public.gmane.org>
2017-06-02 23:40 ` [PATCH v3 3/7] dt-bindings: net: Document Intel pch_gbe binding Paul Burton
2017-06-02 23:40 ` [PATCH v3 4/7] net: pch_gbe: Add device tree support Paul Burton
2017-06-03 6:36 ` kbuild test robot
2017-06-03 6:36 ` kbuild test robot [this message]
2017-06-02 23:40 ` [PATCH v3 5/7] net: pch_gbe: Always reset PHY along with MAC Paul Burton
2017-06-02 23:40 ` [PATCH v3 6/7] net: pch_gbe: Allow longer for resets Paul Burton
2017-06-06 14:10 ` Marcin Nowakowski
2017-06-02 23:40 ` [PATCH v3 7/7] net: pch_gbe: Allow build on MIPS platforms Paul Burton
2017-06-05 17:31 ` [PATCH v4 0/7] net: pch_gbe: Fixes & MIPS support Paul Burton
2017-06-05 17:31 ` [PATCH v4 1/7] net: pch_gbe: Mark Minnow PHY reset GPIO active low Paul Burton
2017-06-05 17:31 ` [PATCH v4 2/7] net: pch_gbe: Pull PHY GPIO handling out of Minnow code Paul Burton
2017-06-05 18:55 ` Andrew Lunn
[not found] ` <20170605173136.10795-1-paul.burton-1AXoQHu6uovQT0dZR+AlfA@public.gmane.org>
2017-06-05 17:31 ` [PATCH v4 3/7] dt-bindings: net: Document Intel pch_gbe binding Paul Burton
[not found] ` <20170605173136.10795-4-paul.burton-1AXoQHu6uovQT0dZR+AlfA@public.gmane.org>
2017-06-05 18:45 ` Sergei Shtylyov
2017-06-09 13:21 ` Rob Herring
2017-06-05 17:31 ` [PATCH v4 4/7] net: pch_gbe: Add device tree support Paul Burton
2017-06-05 18:54 ` Andrew Lunn
2017-06-05 17:31 ` [PATCH v4 5/7] net: pch_gbe: Always reset PHY along with MAC Paul Burton
2017-06-05 17:31 ` [PATCH v4 6/7] net: pch_gbe: Allow longer for resets Paul Burton
2017-06-05 17:31 ` [PATCH v4 7/7] net: pch_gbe: Allow build on MIPS platforms Paul Burton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170603063642.GA10389@lkp-wsm-ep2 \
--to=lkp@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jarod@redhat.com \
--cc=kbuild-all@01.org \
--cc=linux-mips@linux-mips.org \
--cc=netdev@vger.kernel.org \
--cc=paul.burton@imgtec.com \
--cc=tklauser@distanz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).