From: David Miller <davem@davemloft.net>
To: colin.king@canonical.com
Cc: peppe.cavallaro@st.com, alexandre.torgue@st.com,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: stmmac: ensure jumbo_frm error return is correctly checked for -ve value
Date: Sun, 04 Jun 2017 19:58:15 -0400 (EDT) [thread overview]
Message-ID: <20170604.195815.1578427347580474114.davem@davemloft.net> (raw)
In-Reply-To: <20170602145827.21151-1-colin.king@canonical.com>
From: Colin King <colin.king@canonical.com>
Date: Fri, 2 Jun 2017 15:58:27 +0100
> From: Colin Ian King <colin.king@canonical.com>
>
> The current comparison of entry < 0 will never be true since entry is an
> unsigned integer. Cast entry to an int to ensure -ve error return values
> from the call to jumbo_frm are correctly being caught.
>
> Detected by CoverityScan, CID#1238760 ("Macro compares unsigned to 0")
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Like others have suggested, probably making 'entry' signed is
a better fix.
I was initially worried that STMMAC_GET_ENTRY() might become
more expensive if it was implemented using '%' but it is using
'and' masking instead which doesn't have that kind of problem.
prev parent reply other threads:[~2017-06-04 23:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-02 14:58 [PATCH] net: stmmac: ensure jumbo_frm error return is correctly checked for -ve value Colin King
2017-06-03 15:55 ` Andy Shevchenko
2017-06-03 16:35 ` Colin Ian King
2017-06-03 16:53 ` Julia Lawall
2017-06-03 17:18 ` Andy Shevchenko
2017-06-04 23:58 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170604.195815.1578427347580474114.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alexandre.torgue@st.com \
--cc=colin.king@canonical.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).