From: David Miller <davem@davemloft.net>
To: e@erig.me
Cc: pshelar@ovn.org, netdev@vger.kernel.org
Subject: Re: [PATCH net] geneve: fix needed_headroom and max_mtu for collect_metadata
Date: Sun, 04 Jun 2017 20:04:27 -0400 (EDT) [thread overview]
Message-ID: <20170604.200427.359347649096470847.davem@davemloft.net> (raw)
In-Reply-To: <20170602185410.10971-1-e@erig.me>
From: Eric Garver <e@erig.me>
Date: Fri, 2 Jun 2017 14:54:10 -0400
> Since commit 9b4437a5b870 ("geneve: Unify LWT and netdev handling.")
> when using COLLECT_METADATA geneve devices are created with too small of
> a needed_headroom and too large of a max_mtu. This is because
> ip_tunnel_info_af() is not valid with the device level info when using
> COLLECT_METADATA and we mistakenly fall into the IPv4 case.
>
> For COLLECT_METADATA, always use the worst case of ipv6 since both
> sockets are created.
>
> Fixes: 9b4437a5b870 ("geneve: Unify LWT and netdev handling.")
> Signed-off-by: Eric Garver <e@erig.me>
Applied and queued up for -stable, thanks.
prev parent reply other threads:[~2017-06-05 0:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-02 18:54 [PATCH net] geneve: fix needed_headroom and max_mtu for collect_metadata Eric Garver
2017-06-04 5:34 ` Pravin Shelar
2017-06-05 0:04 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170604.200427.359347649096470847.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=e@erig.me \
--cc=netdev@vger.kernel.org \
--cc=pshelar@ovn.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).