From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] net-next: stmmac: dwmac-sun8i: ensure the EPHY is properly reseted Date: Mon, 05 Jun 2017 11:23:37 -0400 (EDT) Message-ID: <20170605.112337.1925463603967545555.davem@davemloft.net> References: <20170604175323.62124-1-icenowy@aosc.io> Reply-To: davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: clabbe.montjoie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org To: icenowy-h8G6r0blFSE@public.gmane.org Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org In-Reply-To: <20170604175323.62124-1-icenowy-h8G6r0blFSE@public.gmane.org> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , List-Id: netdev.vger.kernel.org From: Icenowy Zheng Date: Mon, 5 Jun 2017 01:53:23 +0800 > The EPHY may be already enabled by bootloaders which have Ethernet > capability (e.g. current U-Boot). Thus it should be reseted properly > before doing the enabling sequence in the dwmac-sun8i driver, otherwise > the EMAC reset process may fail if no cable is plugged, and then fail > the dwmac-sun8i probing. > > Tested on Orange Pi PC, One and Zero. All the boards fail to have > dwmac-sun8i probed with "EMAC reset timeout" without cable plugged > before, and with this fix they're now all able to successfully probe the > EMAC without cable plugged and then use the connection after a cable is > hot-plugged in. > > Fixes: 9f93ac8d408 ("net-next: stmmac: Add dwmac-sun8i") > Signed-off-by: Icenowy Zheng Applied, thanks.