From: David Miller <davem@davemloft.net>
To: andrew@lunn.ch
Cc: chunkeey@googlemail.com, netdev@vger.kernel.org, ivan@de.ibm.com,
chrisrblake93@gmail.com
Subject: Re: [PATCH v1 1/2] net: emac: fix reset timeout with AR8035 phy
Date: Mon, 05 Jun 2017 17:54:57 -0400 (EDT) [thread overview]
Message-ID: <20170605.175457.683161131295339666.davem@davemloft.net> (raw)
In-Reply-To: <20170605214857.GB12386@lunn.ch>
From: Andrew Lunn <andrew@lunn.ch>
Date: Mon, 5 Jun 2017 23:48:57 +0200
> On Mon, Jun 05, 2017 at 11:44:46PM +0200, Christian Lamparter wrote:
>> On Monday, June 5, 2017 11:26:17 PM CEST Andrew Lunn wrote:
>> > > In order to stay compatible with existing configurations, the
>> > > driver will try the normal reset first and only falls back to
>> > > to the internal clock, after the first reset fails. If the
>> > > second reset fails as well, it will give up as before.
>> >
>> > Hi Christian
>> >
>> > This gets things probed correctly. But should you swap back to the PHY
>> > clock when the PHY declares the link up? Is there code already to do
>> > this?
>> >
>> > Andrew
>> >
>> Oh, sorry. I omitted this from the commit message. But the proposed
>> emac_reset() code switched to the internal clock only after the first attempt
>> has failed AND only for the duration of the reset.
>>
>> If the reset succeeds or the reset times out, the clock is always switched
>> back to the external clock.
>
> Thanks for the clarification. Maybe add it to the commit message.
Indeed, please do.
next prev parent reply other threads:[~2017-06-05 21:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-05 20:49 [PATCH v1 1/2] net: emac: fix reset timeout with AR8035 phy Christian Lamparter
2017-06-05 20:49 ` [PATCH v1 2/2] net: emac: fix and unify emac_mdio functions Christian Lamparter
2017-06-05 21:43 ` Andrew Lunn
2017-06-05 22:22 ` Christian Lamparter
2017-06-05 21:26 ` [PATCH v1 1/2] net: emac: fix reset timeout with AR8035 phy Andrew Lunn
2017-06-05 21:44 ` Christian Lamparter
2017-06-05 21:48 ` Andrew Lunn
2017-06-05 21:54 ` David Miller [this message]
2017-06-06 5:00 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170605.175457.683161131295339666.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrew@lunn.ch \
--cc=chrisrblake93@gmail.com \
--cc=chunkeey@googlemail.com \
--cc=ivan@de.ibm.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).