From: Andrew Lunn <andrew@lunn.ch>
To: Christian Lamparter <chunkeey@googlemail.com>
Cc: netdev@vger.kernel.org, "David S . Miller" <davem@davemloft.net>,
Ivan Mikhaylov <ivan@de.ibm.com>
Subject: Re: [PATCH v1 2/2] net: emac: fix and unify emac_mdio functions
Date: Mon, 5 Jun 2017 23:43:33 +0200 [thread overview]
Message-ID: <20170605214333.GA12386@lunn.ch> (raw)
In-Reply-To: <18472d9a6bde3edaab7dcda301ccaebd437ea0dc.1496695540.git.chunkeey@googlemail.com>
On Mon, Jun 05, 2017 at 10:49:40PM +0200, Christian Lamparter wrote:
> emac_mdio_read_link() was not copying the requested phy settings
> back into the emac driver's own phy api. This has caused a link
> speed mismatch issue for the AR8035 as the emac driver kept
> trying to connect with 10/100MBps on a 1GBit/s link.
Hi Christian
In the long run, you might want to remove the emac phy drivers. Linux
has PHYLIB drivers for all but the bcm5248.
Andrew
next prev parent reply other threads:[~2017-06-05 21:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-05 20:49 [PATCH v1 1/2] net: emac: fix reset timeout with AR8035 phy Christian Lamparter
2017-06-05 20:49 ` [PATCH v1 2/2] net: emac: fix and unify emac_mdio functions Christian Lamparter
2017-06-05 21:43 ` Andrew Lunn [this message]
2017-06-05 22:22 ` Christian Lamparter
2017-06-05 21:26 ` [PATCH v1 1/2] net: emac: fix reset timeout with AR8035 phy Andrew Lunn
2017-06-05 21:44 ` Christian Lamparter
2017-06-05 21:48 ` Andrew Lunn
2017-06-05 21:54 ` David Miller
2017-06-06 5:00 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170605214333.GA12386@lunn.ch \
--to=andrew@lunn.ch \
--cc=chunkeey@googlemail.com \
--cc=davem@davemloft.net \
--cc=ivan@de.ibm.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).