From: David Miller <davem@davemloft.net>
To: colin.king@canonical.com
Cc: yotamg@mellanox.com, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][net-next] net/mlxfw: remove redundant goto on error check
Date: Tue, 06 Jun 2017 12:22:50 -0400 (EDT) [thread overview]
Message-ID: <20170606.122250.1431459979681086413.davem@davemloft.net> (raw)
In-Reply-To: <20170606104740.15712-1-colin.king@canonical.com>
From: Colin King <colin.king@canonical.com>
Date: Tue, 6 Jun 2017 11:47:40 +0100
> From: Colin Ian King <colin.king@canonical.com>
>
> The check to see of err is set and the subsequent goto is extraneous
> as the next statement is where the goto is jumping to. Remove this
> redundant check and goto.
>
> Detected by CoverityScan, CID#1437734 ("Identical code for
> different branches")
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied, thanks.
prev parent reply other threads:[~2017-06-06 16:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-06 10:47 [PATCH][net-next] net/mlxfw: remove redundant goto on error check Colin King
2017-06-06 10:53 ` Yotam Gigi
2017-06-06 16:22 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170606.122250.1431459979681086413.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=colin.king@canonical.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yotamg@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).