From: David Miller <davem@davemloft.net>
To: stephen@networkplumber.org
Cc: netdev@vger.kernel.org, sthemmin@microsoft.com
Subject: Re: [PATCH net 3/3] netvsc: fix RCU warning from set_multicast
Date: Tue, 06 Jun 2017 15:55:35 -0400 (EDT) [thread overview]
Message-ID: <20170606.155535.23372127948331236.davem@davemloft.net> (raw)
In-Reply-To: <20170605211010.9571-4-sthemmin@microsoft.com>
From: Stephen Hemminger <stephen@networkplumber.org>
Date: Mon, 5 Jun 2017 14:10:10 -0700
> + nvdev = rtnl_dereference(ndevctx->nvdev);
> + if (nvdev)
> + rdev = nvdev->extension;
> +
> + if (rdev) {
> + if (ndev->flags & IFF_PROMISC)
> + rndis_filter_set_packet_filter(rdev,
> + NDIS_PACKET_TYPE_PROMISCUOUS);
> + else
> + rndis_filter_set_packet_filter(rdev,
> + NDIS_PACKET_TYPE_BROADCAST |
> + NDIS_PACKET_TYPE_ALL_MULTICAST |
> + NDIS_PACKET_TYPE_DIRECTED);
> + }
> + }
Stephen, please at least compile test your code.
This is getting rediculous.
prev parent reply other threads:[~2017-06-06 19:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-05 21:10 [PATCH net 0/3] netvsc bug fixes Stephen Hemminger
2017-06-05 21:10 ` [PATCH net 1/3] netvsc: fix rcu dereference warning from ethtool Stephen Hemminger
2017-06-05 21:10 ` [PATCH net 2/3] netvsc: fix net poll mode Stephen Hemminger
2017-06-05 21:10 ` [PATCH net 3/3] netvsc: fix RCU warning from set_multicast Stephen Hemminger
2017-06-06 5:17 ` kbuild test robot
2017-06-06 5:24 ` kbuild test robot
2017-06-06 19:55 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170606.155535.23372127948331236.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
--cc=sthemmin@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).