From: Ganesh Goudar <ganeshgr@chelsio.com>
To: "Mintz, Yuval" <Yuval.Mintz@cavium.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"nirranjan@chelsio.com" <nirranjan@chelsio.com>,
"kumaras@chelsio.com" <kumaras@chelsio.com>
Subject: Re: [PATCH] cxgb4: implement ndo_set_vf_rate()
Date: Tue, 6 Jun 2017 12:13:03 +0530 [thread overview]
Message-ID: <20170606064301.GA12125@chelsio.com> (raw)
In-Reply-To: <BLUPR0701MB2004623B3F087A8213B2AEBF8DCA0@BLUPR0701MB2004.namprd07.prod.outlook.com>
On Monday, June 06/05/17, 2017 at 14:03:14 +0000, Mintz, Yuval wrote:
> > + pktsize = be16_to_cpu(port_rpl.u.info.mtu);
> > + /* subtract ethhdr size and 4 bytes crc since, f/w appends it */
> > + pktsize = pktsize - sizeof(struct ethhdr) - 4;
> > + /* subtract ipv4 hdr size, tcp hdr size to get typical IPv4 MSS size */
> > + pktsize = pktsize - sizeof(struct iphdr) - sizeof(struct tcphdr);
> > + /* configure Traffic Class for rate-limiting */
> > + ret = t4_sched_params(adap, SCHED_CLASS_TYPE_PACKET,
> > + SCHED_CLASS_LEVEL_CL_RL,
> > + SCHED_CLASS_MODE_CLASS,
> > + SCHED_CLASS_RATEUNIT_BITS,
> > + SCHED_CLASS_RATEMODE_ABS,
> > + pi->port_id, class_id, 0,
> > + max_tx_rate * 1000, 0, pktsize);
>
> Does it mean you're achieving throughput limitation by
> limiting the PP/s?
By bits/sec.
next prev parent reply other threads:[~2017-06-06 6:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-05 13:04 [PATCH] cxgb4: implement ndo_set_vf_rate() Ganesh Goudar
2017-06-05 14:03 ` Mintz, Yuval
2017-06-06 6:43 ` Ganesh Goudar [this message]
2017-06-06 19:17 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170606064301.GA12125@chelsio.com \
--to=ganeshgr@chelsio.com \
--cc=Yuval.Mintz@cavium.com \
--cc=davem@davemloft.net \
--cc=kumaras@chelsio.com \
--cc=netdev@vger.kernel.org \
--cc=nirranjan@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).