From: Steffen Klassert <steffen.klassert@secunet.com>
To: Hangbin Liu <liuhangbin@gmail.com>
Cc: <netdev@vger.kernel.org>, Guy Shapiro <guysh@mellanox.com>,
David Miller <davem@davemloft.net>
Subject: Re: [PATCH v2] xfrm: fix xfrm_dev_event() missing when compile without CONFIG_XFRM_OFFLOAD
Date: Tue, 6 Jun 2017 10:06:58 +0200 [thread overview]
Message-ID: <20170606080658.GO2631@secunet.com> (raw)
In-Reply-To: <1496300276-30901-1-git-send-email-liuhangbin@gmail.com>
On Thu, Jun 01, 2017 at 02:57:56PM +0800, Hangbin Liu wrote:
> In commit d77e38e612a0 ("xfrm: Add an IPsec hardware offloading API") we
> make xfrm_device.o only compiled when enable option CONFIG_XFRM_OFFLOAD.
> But this will make xfrm_dev_event() missing if we only enable default XFRM
> options.
>
> Then if we set down and unregister an interface with IPsec on it.
You should not be able to register an interface with IPsec offload
without CONFIG_XFRM_OFFLOAD.
> there
> will no xfrm_garbage_collect(), which will cause dev usage count hold and
> get error like:
>
> unregister_netdevice: waiting for <dev> to become free. Usage count = 4
Can you explain how to reproduce this?
next prev parent reply other threads:[~2017-06-06 8:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-01 0:38 [PATCH] xfrm: fix xfrm_dev_event() missing when compile without CONFIG_XFRM_OFFLOAD Hangbin Liu
2017-06-01 5:20 ` kbuild test robot
2017-06-01 6:57 ` [PATCH v2] " Hangbin Liu
2017-06-06 8:06 ` Steffen Klassert [this message]
2017-06-06 9:26 ` Hangbin Liu
2017-06-07 10:59 ` Steffen Klassert
2017-06-07 10:59 ` Steffen Klassert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170606080658.GO2631@secunet.com \
--to=steffen.klassert@secunet.com \
--cc=davem@davemloft.net \
--cc=guysh@mellanox.com \
--cc=liuhangbin@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).