Re: [PATCH] net: mvpp2: do not bypass the mvpp22_port_mii_set function

[Antoine Tenart <antoine.tenart@free-electrons.com>]

[-- Attachment #1: Type: text/plain, Size: 1055 bytes --]

Hello Thomas,

On Tue, Jun 06, 2017 at 03:45:35PM +0200, Thomas Petazzoni wrote:
> On Tue,  6 Jun 2017 15:36:15 +0200, Antoine Tenart wrote:
> > The mvpp22_port_mii_set() function was added by 2697582144dd, but the
> > function directly returns without doing anything. This return was used
> > when debugging and wasn't removed before sending the patch. Fix this.
> > 
> > Signed-off-by: Antoine Tenart <antoine.tenart@free-electrons.com>
> 
> Please add:
> 
> Fixes: 2697582144dd ("net: mvpp2: handle misc PPv2.1/PPv2.2 differences")
> 
> with this:
> 
> Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

OK, will do.

> I am wondering if we shouldn't Cc: stable as well. I don't think we
> have seen issues on our side because U-Boot does the necessary
> initialization, but people using other bootloaders might have issues.

Yes, that might be safer to cc stable. I'll do this as well.

Thanks,
Antoine

-- 
Antoine Ténart, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]