* [PATCH net] bnx2x: fix pf2vf bulletin DMA mapping leak
@ 2017-06-06 14:30 Michal Schmidt
2017-06-07 14:23 ` Mintz, Yuval
2017-06-07 17:00 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Michal Schmidt @ 2017-06-06 14:30 UTC (permalink / raw)
To: netdev; +Cc: Yuval.Mintz
When freeing VF's DMA mappings, an already NULLed pointer was checked
again due to an apparent copy&paste error. Consequently, the pf2vf
bulletin DMA mapping was not freed.
Signed-off-by: Michal Schmidt <mschmidt@redhat.com>
---
drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c
index bdfd53b46b..870ea001a7 100644
--- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c
+++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c
@@ -3042,7 +3042,7 @@ void bnx2x_vf_pci_dealloc(struct bnx2x *bp)
{
BNX2X_PCI_FREE(bp->vf2pf_mbox, bp->vf2pf_mbox_mapping,
sizeof(struct bnx2x_vf_mbx_msg));
- BNX2X_PCI_FREE(bp->vf2pf_mbox, bp->pf2vf_bulletin_mapping,
+ BNX2X_PCI_FREE(bp->pf2vf_bulletin, bp->pf2vf_bulletin_mapping,
sizeof(union pf_vf_bulletin));
}
--
2.13.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* RE: [PATCH net] bnx2x: fix pf2vf bulletin DMA mapping leak
2017-06-06 14:30 [PATCH net] bnx2x: fix pf2vf bulletin DMA mapping leak Michal Schmidt
@ 2017-06-07 14:23 ` Mintz, Yuval
2017-06-07 17:00 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Mintz, Yuval @ 2017-06-07 14:23 UTC (permalink / raw)
To: Michal Schmidt, netdev@vger.kernel.org
> When freeing VF's DMA mappings, an already NULLed pointer was checked
> again due to an apparent copy&paste error. Consequently, the pf2vf bulletin
> DMA mapping was not freed.
>
> Signed-off-by: Michal Schmidt <mschmidt@redhat.com>
Thanks Michal.
Acked-by: Yuval Mintz <Yuval.Mintz@cavium.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net] bnx2x: fix pf2vf bulletin DMA mapping leak
2017-06-06 14:30 [PATCH net] bnx2x: fix pf2vf bulletin DMA mapping leak Michal Schmidt
2017-06-07 14:23 ` Mintz, Yuval
@ 2017-06-07 17:00 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2017-06-07 17:00 UTC (permalink / raw)
To: mschmidt; +Cc: netdev, Yuval.Mintz
From: Michal Schmidt <mschmidt@redhat.com>
Date: Tue, 6 Jun 2017 16:30:31 +0200
> When freeing VF's DMA mappings, an already NULLed pointer was checked
> again due to an apparent copy&paste error. Consequently, the pf2vf
> bulletin DMA mapping was not freed.
>
> Signed-off-by: Michal Schmidt <mschmidt@redhat.com>
Applied, thank you.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-06-07 17:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-06-06 14:30 [PATCH net] bnx2x: fix pf2vf bulletin DMA mapping leak Michal Schmidt
2017-06-07 14:23 ` Mintz, Yuval
2017-06-07 17:00 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).