Netdev List
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next] tcp: add TCPMemoryPressuresChrono counter
Date: Wed, 07 Jun 2017 14:54:48 -0400 (EDT)	[thread overview]
Message-ID: <20170607.145448.152856288455996460.davem@davemloft.net> (raw)
In-Reply-To: <1496776767.736.11.camel@edumazet-glaptop3.roam.corp.google.com>

From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Tue, 06 Jun 2017 12:19:27 -0700

> @@ -320,18 +320,37 @@ struct tcp_splice_state {
>   * All the __sk_mem_schedule() is of this nature: accounting
>   * is strict, actions are advisory and have some latency.
>   */
> -int tcp_memory_pressure __read_mostly;
> +unsigned long tcp_memory_pressure __read_mostly;
>  EXPORT_SYMBOL(tcp_memory_pressure);

I know it is not strictly related to your change, but if you are
adding new exports in this area let's do it properly.

The existing tcp_memory_pressure export, as well as these two:

...
>  EXPORT_SYMBOL(tcp_enter_memory_pressure);
...
> +EXPORT_SYMBOL(tcp_leave_memory_pressure);

ought to be EXPORT_SYMBOL_GPL().  They are exported for the sake of
ipv6 TCP support, and nothing else.

I'll apply this with that fixed.

Thanks Eric.

  reply	other threads:[~2017-06-07 18:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-06 19:19 [PATCH net-next] tcp: add TCPMemoryPressuresChrono counter Eric Dumazet
2017-06-07 18:54 ` David Miller [this message]
2017-06-07 20:23   ` Eric Dumazet
2017-06-07 20:29 ` [PATCH v2 " Eric Dumazet
2017-06-08 15:26   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170607.145448.152856288455996460.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox