* [net-next] vxlan: use a more suitable function when assigning NULL
@ 2017-06-07 11:36 Mark Bloch
2017-06-07 19:26 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Mark Bloch @ 2017-06-07 11:36 UTC (permalink / raw)
To: jbenc, stephen; +Cc: netdev
When stopping the vxlan interface we detach it from the socket.
Use RCU_INIT_POINTER() and not rcu_assign_pointer() to do so.
Suggested-by: Stephen Hemminger <stephen@networkplumber.org>
Signed-off-by: Mark Bloch <markb@mellanox.com>
---
drivers/net/vxlan.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c
index a6b5052..7cb21a0 100644
--- a/drivers/net/vxlan.c
+++ b/drivers/net/vxlan.c
@@ -1077,10 +1077,10 @@ static void vxlan_sock_release(struct vxlan_dev *vxlan)
#if IS_ENABLED(CONFIG_IPV6)
struct vxlan_sock *sock6 = rtnl_dereference(vxlan->vn6_sock);
- rcu_assign_pointer(vxlan->vn6_sock, NULL);
+ RCU_INIT_POINTER(vxlan->vn6_sock, NULL);
#endif
- rcu_assign_pointer(vxlan->vn4_sock, NULL);
+ RCU_INIT_POINTER(vxlan->vn4_sock, NULL);
synchronize_net();
vxlan_vs_del_dev(vxlan);
--
1.8.4.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [net-next] vxlan: use a more suitable function when assigning NULL
2017-06-07 11:36 [net-next] vxlan: use a more suitable function when assigning NULL Mark Bloch
@ 2017-06-07 19:26 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2017-06-07 19:26 UTC (permalink / raw)
To: markb; +Cc: jbenc, stephen, netdev
From: Mark Bloch <markb@mellanox.com>
Date: Wed, 7 Jun 2017 14:36:58 +0300
> When stopping the vxlan interface we detach it from the socket.
> Use RCU_INIT_POINTER() and not rcu_assign_pointer() to do so.
>
> Suggested-by: Stephen Hemminger <stephen@networkplumber.org>
> Signed-off-by: Mark Bloch <markb@mellanox.com>
Applied, thanks Mark.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-06-07 19:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-06-07 11:36 [net-next] vxlan: use a more suitable function when assigning NULL Mark Bloch
2017-06-07 19:26 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).