From: David Miller <davem@davemloft.net>
To: sfr@canb.auug.org.au
Cc: netdev@vger.kernel.org, broonie@kernel.org,
linaro-kernel@lists.linaro.org, linux-next@vger.kernel.org
Subject: Re: next-20170608 build: 1 failures 4 warnings (next-20170608)
Date: Thu, 08 Jun 2017 10:16:27 -0400 (EDT) [thread overview]
Message-ID: <20170608.101627.1876505383531574064.davem@davemloft.net> (raw)
In-Reply-To: <20170608202704.1469d0bf@canb.auug.org.au>
From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Thu, 8 Jun 2017 20:27:04 +1000
> Hi Dave,
>
> On Thu, 08 Jun 2017 10:57:50 +0100 Build bot for Mark Brown <broonie@kernel.org> wrote:
>>
>> Tree/Branch: next-20170608
>> Git describe: next-20170608
>> Commit: e4689b9aad Add linux-next specific files for 20170608
>>
>> Build Time: 0 min 12 sec
>>
>> Passed: 6 / 7 ( 85.71 %)
>> Failed: 1 / 7 ( 14.29 %)
>>
>> Errors: 1
>> Warnings: 4
>> Section Mismatches: 0
>>
>> Failed defconfigs:
>> arm-allmodconfig
>>
>> Errors:
>>
>> arm-allmodconfig
>> ../drivers/hsi/clients/ssi_protocol.c:1069:5: error: 'struct net_device' has no member named 'destructor'
>
> Looks like Mark has found another one.
This should fix it, pushed out to 'net'.
Thanks.
====================
[PATCH] hsi: Fix build regression due to netdev destructor fix.
> ../drivers/hsi/clients/ssi_protocol.c:1069:5: error: 'struct net_device' has no member named 'destructor'
Reported-by: Mark Brown <broonie@kernel.org>
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
---
drivers/hsi/clients/ssi_protocol.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hsi/clients/ssi_protocol.c b/drivers/hsi/clients/ssi_protocol.c
index 26b0510..93d28c0 100644
--- a/drivers/hsi/clients/ssi_protocol.c
+++ b/drivers/hsi/clients/ssi_protocol.c
@@ -1066,7 +1066,7 @@ static void ssip_pn_setup(struct net_device *dev)
dev->addr_len = 1;
dev->tx_queue_len = SSIP_TXQUEUE_LEN;
- dev->destructor = free_netdev;
+ dev->needs_free_netdev = true;
dev->header_ops = &phonet_header_ops;
}
--
2.4.11
next prev parent reply other threads:[~2017-06-08 14:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1dIuCM-0000cQ-QM@optimist>
2017-06-08 10:27 ` next-20170608 build: 1 failures 4 warnings (next-20170608) Stephen Rothwell
2017-06-08 14:16 ` David Miller [this message]
2017-06-08 10:32 ` Mark Brown
2017-06-08 11:33 ` Sebastian Reichel
2017-06-08 14:17 ` David Miller
2017-06-08 14:53 ` Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170608.101627.1876505383531574064.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=broonie@kernel.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-next@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).