netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: dsahern@gmail.com
Cc: netdev@vger.kernel.org, roopa@cumulusnetworks.com
Subject: Re: [PATCH net] net: ipv6: Release route when device is unregistering
Date: Thu, 08 Jun 2017 11:13:06 -0400 (EDT)	[thread overview]
Message-ID: <20170608.111306.987099708536491352.davem@davemloft.net> (raw)
In-Reply-To: <20170607182623.20734-1-dsahern@gmail.com>

From: David Ahern <dsahern@gmail.com>
Date: Wed,  7 Jun 2017 12:26:23 -0600

> Roopa reported attempts to delete a bond device that is referenced in a
> multipath route is hanging:
> 
> $ ifdown bond2    # ifupdown2 command that deletes virtual devices
> unregister_netdevice: waiting for bond2 to become free. Usage count = 2
> 
> Steps to reproduce:
>     echo 1 > /proc/sys/net/ipv6/conf/all/ignore_routes_with_linkdown
>     ip link add dev bond12 type bond
>     ip link add dev bond13 type bond
>     ip addr add 2001:db8:2::0/64 dev bond12
>     ip addr add 2001:db8:3::0/64 dev bond13
>     ip route add 2001:db8:33::0/64 nexthop via 2001:db8:2::2 nexthop via 2001:db8:3::2
>     ip link del dev bond12
>     ip link del dev bond13
> 
> The root cause is the recent change to keep routes on a linkdown. Update
> the check to detect when the device is unregistering and release the
> route for that case.
> 
> Fixes: a1a22c12060e4 ("net: ipv6: Keep nexthop of multipath route on admin down")
> Reported-by: Roopa Prabhu <roopa@cumulusnetworks.com>
> Signed-off-by: David Ahern <dsahern@gmail.com>

Applied and queued up for -stable, thanks David.

      parent reply	other threads:[~2017-06-08 15:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-07 18:26 [PATCH net] net: ipv6: Release route when device is unregistering David Ahern
2017-06-07 20:14 ` Roopa Prabhu
2017-06-08 15:13 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170608.111306.987099708536491352.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=dsahern@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=roopa@cumulusnetworks.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).