From: David Miller <davem@davemloft.net>
To: nikolay@cumulusnetworks.com
Cc: netdev@vger.kernel.org, roopa@cumulusnetworks.com,
sharpd@cumulusnetworks.com
Subject: Re: [PATCH net-next v2] net: ipmr: add getlink support
Date: Thu, 08 Jun 2017 14:39:13 -0400 (EDT) [thread overview]
Message-ID: <20170608.143913.800862231155819238.davem@davemloft.net> (raw)
In-Reply-To: <1496847752-6935-1-git-send-email-nikolay@cumulusnetworks.com>
From: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Date: Wed, 7 Jun 2017 18:02:32 +0300
> Currently there's no way to dump the VIF table for an ipmr table other
> than the default (via proc). This is a major issue when debugging ipmr
> issues and in general it is good to know which interfaces are
> configured. This patch adds support for RTM_GETLINK for the ipmr family
> so we can dump the VIF table and the ipmr table's current config for
> each table. We're protected by rtnl so no need to acquire RCU or
> mrt_lock.
>
> Signed-off-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
> ---
> v2: use netlink attributes for all mrtable and vif fields, and set message
> type to RTM_NEWLINK
>
> The plan is to add full netlink control to ipmr via new/set/dellink later.
> Also this would allow us to dump any number of VIFs in the future when we
> remove the VIF device limit.
Applied, thanks Nikolay.
prev parent reply other threads:[~2017-06-08 18:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-06 16:41 [PATCH net-next] net: ipmr: add getlink support Nikolay Aleksandrov
2017-06-07 7:44 ` Nikolay Aleksandrov
2017-06-07 15:02 ` [PATCH net-next v2] " Nikolay Aleksandrov
2017-06-08 18:39 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170608.143913.800862231155819238.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=roopa@cumulusnetworks.com \
--cc=sharpd@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).