From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
To: 严海双 <yanhaishuang@cmss.chinamobile.com>
Cc: "=David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, Eric Dumazet <edumazet@google.com>
Subject: Re: [PATCH v3 2/2] ip6_tunnel: fix potential issue in __ip6_tnl_rcv
Date: Wed, 7 Jun 2017 22:00:43 -0700 [thread overview]
Message-ID: <20170608050041.cte3gpavshg2nmdc@ast-mbp> (raw)
In-Reply-To: <3A078CA0-C9C8-45D2-A359-1FB38B25792D@cmss.chinamobile.com>
On Thu, Jun 08, 2017 at 12:56:58PM +0800, 严海双 wrote:
>
> > On 8 Jun 2017, at 12:38 PM, Alexei Starovoitov <alexei.starovoitov@gmail.com> wrote:
> >
> > On Thu, Jun 08, 2017 at 12:32:44PM +0800, Haishuang Yan wrote:
> >> When __ip6_tnl_rcv fails, the tun_dst won't be freed, so call
> >> dst_release to free it in error code path.
> >>
> >> CC: Alexei Starovoitov <ast@fb.com>
> >> Fixes: 8d79266bc48c ("ip6_tunnel: add collect_md mode to IPv6 tunnels")
> >> Signed-off-by: Haishuang Yan <yanhaishuang@cmss.chinamobile.com>
> >
> > I don't get it. Why did you send another version of the patch?
> > What was wrong with previous approach that myself and Eric acked?
> >
> >
>
> Sorry for your confusing, because Pravin Shelar give a feedback in ipv4 patch, see below:
hmm. right.
Then it raises the question: How did you test this and previous patch?
since previous version was sort-of fixing the bug, but completely
breaking the logic...
next prev parent reply other threads:[~2017-06-08 5:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-08 4:32 [PATCH v3 1/2] ip_tunnel: fix potential issue in ip_tunnel_rcv Haishuang Yan
2017-06-08 4:32 ` [PATCH v3 2/2] ip6_tunnel: fix potential issue in __ip6_tnl_rcv Haishuang Yan
2017-06-08 4:38 ` Alexei Starovoitov
2017-06-08 4:50 ` Eric Dumazet
[not found] ` <3A078CA0-C9C8-45D2-A359-1FB38B25792D@cmss.chinamobile.com>
2017-06-08 5:00 ` Alexei Starovoitov [this message]
2017-06-08 7:33 ` 严海双
2017-06-08 13:59 ` David Miller
2017-06-09 0:23 ` 严海双
2017-06-08 13:18 ` David Miller
2017-06-08 4:54 ` [PATCH v3 1/2] ip_tunnel: fix potential issue in ip_tunnel_rcv Eric Dumazet
2017-06-08 21:47 ` Pravin Shelar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170608050041.cte3gpavshg2nmdc@ast-mbp \
--to=alexei.starovoitov@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=netdev@vger.kernel.org \
--cc=yanhaishuang@cmss.chinamobile.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).