* Re: next-20170608 build: 1 failures 4 warnings (next-20170608) [not found] <E1dIuCM-0000cQ-QM@optimist> @ 2017-06-08 10:27 ` Stephen Rothwell 2017-06-08 14:16 ` David Miller 2017-06-08 10:32 ` Mark Brown 1 sibling, 1 reply; 6+ messages in thread From: Stephen Rothwell @ 2017-06-08 10:27 UTC (permalink / raw) To: David Miller, Networking Cc: Build bot for Mark Brown, linaro-kernel, linux-next Hi Dave, On Thu, 08 Jun 2017 10:57:50 +0100 Build bot for Mark Brown <broonie@kernel.org> wrote: > > Tree/Branch: next-20170608 > Git describe: next-20170608 > Commit: e4689b9aad Add linux-next specific files for 20170608 > > Build Time: 0 min 12 sec > > Passed: 6 / 7 ( 85.71 %) > Failed: 1 / 7 ( 14.29 %) > > Errors: 1 > Warnings: 4 > Section Mismatches: 0 > > Failed defconfigs: > arm-allmodconfig > > Errors: > > arm-allmodconfig > ../drivers/hsi/clients/ssi_protocol.c:1069:5: error: 'struct net_device' has no member named 'destructor' Looks like Mark has found another one. -- Cheers, Stephen Rothwell ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: next-20170608 build: 1 failures 4 warnings (next-20170608) 2017-06-08 10:27 ` next-20170608 build: 1 failures 4 warnings (next-20170608) Stephen Rothwell @ 2017-06-08 14:16 ` David Miller 0 siblings, 0 replies; 6+ messages in thread From: David Miller @ 2017-06-08 14:16 UTC (permalink / raw) To: sfr; +Cc: netdev, broonie, linaro-kernel, linux-next From: Stephen Rothwell <sfr@canb.auug.org.au> Date: Thu, 8 Jun 2017 20:27:04 +1000 > Hi Dave, > > On Thu, 08 Jun 2017 10:57:50 +0100 Build bot for Mark Brown <broonie@kernel.org> wrote: >> >> Tree/Branch: next-20170608 >> Git describe: next-20170608 >> Commit: e4689b9aad Add linux-next specific files for 20170608 >> >> Build Time: 0 min 12 sec >> >> Passed: 6 / 7 ( 85.71 %) >> Failed: 1 / 7 ( 14.29 %) >> >> Errors: 1 >> Warnings: 4 >> Section Mismatches: 0 >> >> Failed defconfigs: >> arm-allmodconfig >> >> Errors: >> >> arm-allmodconfig >> ../drivers/hsi/clients/ssi_protocol.c:1069:5: error: 'struct net_device' has no member named 'destructor' > > Looks like Mark has found another one. This should fix it, pushed out to 'net'. Thanks. ==================== [PATCH] hsi: Fix build regression due to netdev destructor fix. > ../drivers/hsi/clients/ssi_protocol.c:1069:5: error: 'struct net_device' has no member named 'destructor' Reported-by: Mark Brown <broonie@kernel.org> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> Signed-off-by: David S. Miller <davem@davemloft.net> --- drivers/hsi/clients/ssi_protocol.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hsi/clients/ssi_protocol.c b/drivers/hsi/clients/ssi_protocol.c index 26b0510..93d28c0 100644 --- a/drivers/hsi/clients/ssi_protocol.c +++ b/drivers/hsi/clients/ssi_protocol.c @@ -1066,7 +1066,7 @@ static void ssip_pn_setup(struct net_device *dev) dev->addr_len = 1; dev->tx_queue_len = SSIP_TXQUEUE_LEN; - dev->destructor = free_netdev; + dev->needs_free_netdev = true; dev->header_ops = &phonet_header_ops; } -- 2.4.11 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: next-20170608 build: 1 failures 4 warnings (next-20170608) [not found] <E1dIuCM-0000cQ-QM@optimist> 2017-06-08 10:27 ` next-20170608 build: 1 failures 4 warnings (next-20170608) Stephen Rothwell @ 2017-06-08 10:32 ` Mark Brown 2017-06-08 11:33 ` Sebastian Reichel 1 sibling, 1 reply; 6+ messages in thread From: Mark Brown @ 2017-06-08 10:32 UTC (permalink / raw) To: David S. Miller, Sebastian Reichel Cc: kernel-build-reports, linaro-kernel, linux-next, netdev [-- Attachment #1: Type: text/plain, Size: 512 bytes --] On Thu, Jun 08, 2017 at 10:57:50AM +0100, Build bot for Mark Brown wrote: Today's -next fails to build an ARM allmodconfig due to: > arm-allmodconfig > ../drivers/hsi/clients/ssi_protocol.c:1069:5: error: 'struct net_device' has no member named 'destructor' due to cf124db566e6 (net: Fix inconsistent teardown and release of private netdev state.) which missed this instance, presumably due to a combination of it not being in one of the normal networking driver directories and only being buildable on ARM. [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 488 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: next-20170608 build: 1 failures 4 warnings (next-20170608) 2017-06-08 10:32 ` Mark Brown @ 2017-06-08 11:33 ` Sebastian Reichel 2017-06-08 14:17 ` David Miller 0 siblings, 1 reply; 6+ messages in thread From: Sebastian Reichel @ 2017-06-08 11:33 UTC (permalink / raw) To: Mark Brown Cc: David S. Miller, kernel-build-reports, linaro-kernel, linux-next, netdev [-- Attachment #1: Type: text/plain, Size: 744 bytes --] Hi, On Thu, Jun 08, 2017 at 11:32:31AM +0100, Mark Brown wrote: > On Thu, Jun 08, 2017 at 10:57:50AM +0100, Build bot for Mark Brown wrote: > > Today's -next fails to build an ARM allmodconfig due to: > > > arm-allmodconfig > > ../drivers/hsi/clients/ssi_protocol.c:1069:5: error: 'struct net_device' has no member named 'destructor' > > due to cf124db566e6 (net: Fix inconsistent teardown and release of > private netdev state.) which missed this instance, presumably due to a > combination of it not being in one of the normal networking driver > directories and only being buildable on ARM. I assume, that this will be fixed via the net tree. If you Cc me on updated/new patch I will provide Acked-by. -- Sebastian [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: next-20170608 build: 1 failures 4 warnings (next-20170608) 2017-06-08 11:33 ` Sebastian Reichel @ 2017-06-08 14:17 ` David Miller 2017-06-08 14:53 ` Sebastian Reichel 0 siblings, 1 reply; 6+ messages in thread From: David Miller @ 2017-06-08 14:17 UTC (permalink / raw) To: sre; +Cc: broonie, kernel-build-reports, linaro-kernel, linux-next, netdev From: Sebastian Reichel <sre@kernel.org> Date: Thu, 8 Jun 2017 13:33:26 +0200 > Hi, > > On Thu, Jun 08, 2017 at 11:32:31AM +0100, Mark Brown wrote: >> On Thu, Jun 08, 2017 at 10:57:50AM +0100, Build bot for Mark Brown wrote: >> >> Today's -next fails to build an ARM allmodconfig due to: >> >> > arm-allmodconfig >> > ../drivers/hsi/clients/ssi_protocol.c:1069:5: error: 'struct net_device' has no member named 'destructor' >> >> due to cf124db566e6 (net: Fix inconsistent teardown and release of >> private netdev state.) which missed this instance, presumably due to a >> combination of it not being in one of the normal networking driver >> directories and only being buildable on ARM. > > I assume, that this will be fixed via the net tree. > If you Cc me on updated/new patch I will provide Acked-by. It is fixed in the 'net' tree, don't worry about it :-) ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: next-20170608 build: 1 failures 4 warnings (next-20170608) 2017-06-08 14:17 ` David Miller @ 2017-06-08 14:53 ` Sebastian Reichel 0 siblings, 0 replies; 6+ messages in thread From: Sebastian Reichel @ 2017-06-08 14:53 UTC (permalink / raw) To: David Miller Cc: broonie, kernel-build-reports, linaro-kernel, linux-next, netdev [-- Attachment #1: Type: text/plain, Size: 1059 bytes --] Hi, On Thu, Jun 08, 2017 at 10:17:57AM -0400, David Miller wrote: > > On Thu, Jun 08, 2017 at 11:32:31AM +0100, Mark Brown wrote: > >> On Thu, Jun 08, 2017 at 10:57:50AM +0100, Build bot for Mark Brown wrote: > >> > >> Today's -next fails to build an ARM allmodconfig due to: > >> > >> > arm-allmodconfig > >> > ../drivers/hsi/clients/ssi_protocol.c:1069:5: error: 'struct net_device' has no member named 'destructor' > >> > >> due to cf124db566e6 (net: Fix inconsistent teardown and release of > >> private netdev state.) which missed this instance, presumably due to a > >> combination of it not being in one of the normal networking driver > >> directories and only being buildable on ARM. > > > > I assume, that this will be fixed via the net tree. > > If you Cc me on updated/new patch I will provide Acked-by. > > It is fixed in the 'net' tree, don't worry about it :-) https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git/commit/?id=ed66e50d9587fc0bb032e276a2563c0068a5b63a Looks good, thanks. -- Sebastian [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-06-08 14:53 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <E1dIuCM-0000cQ-QM@optimist>
2017-06-08 10:27 ` next-20170608 build: 1 failures 4 warnings (next-20170608) Stephen Rothwell
2017-06-08 14:16 ` David Miller
2017-06-08 10:32 ` Mark Brown
2017-06-08 11:33 ` Sebastian Reichel
2017-06-08 14:17 ` David Miller
2017-06-08 14:53 ` Sebastian Reichel
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).