From: David Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
To: Yuval.Mintz-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org
Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Michal.Kalderon-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org
Subject: Re: [PATCH net-next 1/8] qed: LL2 to use packed information for tx
Date: Fri, 09 Jun 2017 09:59:43 -0400 (EDT) [thread overview]
Message-ID: <20170609.095943.828238777523466278.davem@davemloft.net> (raw)
In-Reply-To: <BLUPR0701MB200415C3D80FB06774CF2C7B8DCE0-v5ruerSQ/oj1oiTf6dR/AE5OhdzP3rhOnBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org>
From: "Mintz, Yuval" <Yuval.Mintz-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>
Date: Fri, 9 Jun 2017 07:08:54 +0000
> But one thing I thought of asking - do we consider layouts of relatively
> insignificant structures to be some golden coding standard?
It just shows lack of thought when writing things.
I want to see code that shows the author put some care into it
and didn't just slap things together.
Thank you.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-06-09 13:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-08 16:13 [PATCH net-next 0/8] qed*: Light L2 updates Yuval Mintz
2017-06-08 16:13 ` [PATCH net-next 1/8] qed: LL2 to use packed information for tx Yuval Mintz
[not found] ` <20170608161323.7597-2-Yuval.Mintz-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>
2017-06-08 23:23 ` David Miller
2017-06-09 7:08 ` Mintz, Yuval
[not found] ` <BLUPR0701MB200415C3D80FB06774CF2C7B8DCE0-v5ruerSQ/oj1oiTf6dR/AE5OhdzP3rhOnBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org>
2017-06-09 13:59 ` David Miller [this message]
2017-06-09 7:28 ` David Laight
2017-06-09 7:51 ` Mintz, Yuval
[not found] ` <BLUPR0701MB2004CA6F1F262EC4E815E6B58DCE0-v5ruerSQ/oj1oiTf6dR/AE5OhdzP3rhOnBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org>
2017-06-09 8:23 ` David Laight
2017-06-08 16:13 ` [PATCH net-next 2/8] qed: Revise ll2 Rx completion Yuval Mintz
[not found] ` <20170608161323.7597-3-Yuval.Mintz-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>
2017-06-08 23:24 ` David Miller
[not found] ` <20170608161323.7597-1-Yuval.Mintz-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>
2017-06-08 16:13 ` [PATCH net-next 3/8] qed: Cleaner seperation of LL2 inputs Yuval Mintz
2017-06-08 16:13 ` [PATCH net-next 7/8] qed: Call rx_release_cb() when flushing LL2 Yuval Mintz
2017-06-08 16:13 ` [PATCH net-next 8/8] qed: collect GSI port statistics Yuval Mintz
2017-06-08 16:13 ` [PATCH net-next 4/8] qed: LL2 code relocations Yuval Mintz
2017-06-08 16:13 ` [PATCH net-next 5/8] qed*: LL2 callback operations Yuval Mintz
2017-06-08 16:13 ` [PATCH net-next 6/8] qed: No need for LL2 frags indication Yuval Mintz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170609.095943.828238777523466278.davem@davemloft.net \
--to=davem-ft/pcqaiutieiz0/mpfg9q@public.gmane.org \
--cc=Michal.Kalderon-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org \
--cc=Yuval.Mintz-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).