From: David Miller <davem@davemloft.net>
To: kjlx@templeofstupid.com
Cc: maheshb@google.com, netdev@vger.kernel.org
Subject: Re: [PATCH v2 net-next] Ipvlan should return an error when an address is already in use.
Date: Fri, 09 Jun 2017 13:15:10 -0400 (EDT) [thread overview]
Message-ID: <20170609.131510.1262676940920520377.davem@davemloft.net> (raw)
In-Reply-To: <20170609171310.GA2766@templeofstupid.com>
From: Krister Johansen <kjlx@templeofstupid.com>
Date: Fri, 9 Jun 2017 10:13:10 -0700
> On Fri, Jun 09, 2017 at 12:26:46PM -0400, David Miller wrote:
>> From: Krister Johansen <kjlx@templeofstupid.com>
>> Date: Thu, 8 Jun 2017 13:12:14 -0700
>>
>> > The ipvlan code already knows how to detect when a duplicate address is
>> > about to be assigned to an ipvlan device. However, that failure is not
>> > propogated outward and leads to a silent failure.
>> >
>> > Introduce a validation step at ip address creation time and allow device
>> > drivers to register to validate the incoming ip addresses. The ipvlan
>> > code is the first consumer. If it detects an address in use, we can
>> > return an error to the user before beginning to commit the new ifa in
>> > the networking code.
>> >
>> > This can be especially useful if it is necessary to provision many
>> > ipvlans in containers. The provisioning software (or operator) can use
>> > this to detect situations where an ip address is unexpectedly in use.
>> >
>> > Signed-off-by: Krister Johansen <kjlx@templeofstupid.com>
>>
>> Ok, applied, thank you.
>
> Thanks, did this look otherwise alright?
Yes, I was mildly unsatisfied with the ipv6 addrconf situation but I know
very well about that, and those kinds of addresses aren't of interest
for what you are trying to achieve right?
next prev parent reply other threads:[~2017-06-09 17:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-31 4:10 [PATCH] Ipvlan should return an error when an address is already in use Krister Johansen
2017-01-02 3:26 ` David Miller
2017-01-04 10:04 ` Krister Johansen
2017-06-08 20:12 ` [PATCH v2 net-next] " Krister Johansen
2017-06-09 16:26 ` David Miller
2017-06-09 17:13 ` Krister Johansen
2017-06-09 17:15 ` David Miller [this message]
2017-06-09 17:25 ` Krister Johansen
2017-01-03 15:50 ` [PATCH] " Aaron Conole
2017-01-03 15:55 ` David Miller
2017-01-03 19:24 ` Aaron Conole
2017-01-04 10:09 ` Krister Johansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170609.131510.1262676940920520377.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=kjlx@templeofstupid.com \
--cc=maheshb@google.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).