From: David Miller <davem@davemloft.net>
To: chenbofeng.kernel@gmail.com
Cc: netdev@vger.kernel.org, lorenzo@google.com, edumazet@google.com,
fengc@google.com
Subject: Re: [PATCH net-next] ipv6: Initial skb->dev and skb->protocol in ip6_output
Date: Fri, 09 Jun 2017 15:39:37 -0400 (EDT) [thread overview]
Message-ID: <20170609.153937.1403217696199851743.davem@davemloft.net> (raw)
In-Reply-To: <3270a030-2608-1629-07d6-7fdeee9e98cc@gmail.com>
From: Chenbo Feng <chenbofeng.kernel@gmail.com>
Date: Fri, 9 Jun 2017 12:13:57 -0700
>
>
> On 06/09/2017 12:08 PM, David Miller wrote:
>> From: Chenbo Feng <chenbofeng.kernel@gmail.com>
>> Date: Fri, 9 Jun 2017 12:06:07 -0700
>>
>>> From: Chenbo Feng <fengc@google.com>
>>>
>>> Move the initialization of skb->dev and skb->protocol from
>>> ip6_finish_output2 to ip6_output. This can make the skb->dev and
>>> skb->protocol information avalaible to the CGROUP eBPF filter.
>>>
>>> Signed-off-by: Chenbo Feng <fengc@google.com>
>>> Acked-by: Eric Dumazet <edumazet@google.com>
>> Applied, thanks.
>>
>> This makes ipv6 consistent with ipv4.
>>
>> I am surprised this wasn't noticed, for example, in netfilter.
>> .
>>
> Hi David,
>
> This patch is still under working since it may have problem with
> ip_fragment() call, did you applied it already? Should I send a revert
> patch to you then?
A revert is necessary or a relative fixup.
Thank you.
next prev parent reply other threads:[~2017-06-09 19:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-09 19:06 [PATCH net-next] ipv6: Initial skb->dev and skb->protocol in ip6_output Chenbo Feng
2017-06-09 19:08 ` David Miller
2017-06-09 19:13 ` Chenbo Feng
2017-06-09 19:24 ` Bjørn Mork
2017-06-09 19:45 ` Chenbo Feng
2017-06-10 14:56 ` Eric Dumazet
2017-06-09 19:39 ` David Miller [this message]
2017-06-09 23:12 ` Chenbo Feng
2017-06-10 14:54 ` Eric Dumazet
[not found] ` <CAMOXUJnJ+e=f3x7gZsh4f=Fn01pspDqMKJFqc7cb7umV8SXtaw@mail.gmail.com>
2017-06-09 19:39 ` David Miller
2017-06-09 21:11 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170609.153937.1403217696199851743.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=chenbofeng.kernel@gmail.com \
--cc=edumazet@google.com \
--cc=fengc@google.com \
--cc=lorenzo@google.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox